add capabilites for animating view transitions and fix a typo#4
Open
juanjovn wants to merge 1 commit intoAbedalkareem:masterfrom
Open
add capabilites for animating view transitions and fix a typo#4juanjovn wants to merge 1 commit intoAbedalkareem:masterfrom
juanjovn wants to merge 1 commit intoAbedalkareem:masterfrom
Conversation
Owner
Abedalkareem
left a comment
Abedalkareem
left a comment
There was a problem hiding this comment.
Hi!
Thank you for contributing,
Don't you think that we need to keep this configurable? I mean what if someone doesn't need this animation?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a function to either animate or not the transition between views when a tab bar element is selected. Also fixed a typo in "contoller" variable.