Skip to content

Fix cancelled subs bug.#186

Merged
Abedalkareem merged 4 commits intodevelopfrom
add-player-stream
Mar 5, 2025
Merged

Fix cancelled subs bug.#186
Abedalkareem merged 4 commits intodevelopfrom
add-player-stream

Conversation

@theLee3
Copy link
Copy Markdown
Collaborator

@theLee3 theLee3 commented Feb 27, 2025

This PR completes the implementation of the player stream. The following changes are included.

  1. [BUG FIX] Set the MethodChannel subscription to null when all listeners are cancelled. Previously just cancelled the sub, which would not allow new subs, as there is a null check before assigning a new sub. Fixes [iOS] GameAuth.isSignedIn not working after user cancel the GameAuth.signIn() #158.

  2. [BUG FIX] Set the cached player to null when an error occurs across the player stream.

  3. [QoL] Make the player stream distinct, meaning that current listeners do not receive duplicate data when new listeners are added or legacy methods are called.

  4. [QoL] Bump iOS deployment target to 12.4 which provides better feedback to the dev when building for iOS, as it is now necessary due to the use of gamePlayerID (playerID is deprecated). It will also be necessary when upgrading from other deprecated GameKit methods.

  5. [QoL] Update some information in the podspec file to match the version number and provide links to the GitHub.

Update information in podspec.
@PacifistaBot
Copy link
Copy Markdown
Collaborator

PacifistaBot commented Feb 27, 2025

Fails
🚫 Flutter analyzer failed. Please fix the issues reported by the analyzer. Error: Command failed: flutter analyze 1 issue found. (ran in 6.9s)
Warnings
⚠️

Please update the CHANGELOG.md file.

⚠️

Please update the documentation in the docs/ folder.

Generated by 🚫 dangerJS against 3ce3f12

@theLee3 theLee3 changed the title Increase iOS deployment target to 12.4. Fix cancelled subs bug. Feb 28, 2025
@Abedalkareem Abedalkareem merged commit 06be38a into develop Mar 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] GameAuth.isSignedIn not working after user cancel the GameAuth.signIn()

3 participants