Merged
Conversation
Update information in podspec.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the implementation of the player stream. The following changes are included.
[BUG FIX] Set the MethodChannel subscription to
nullwhen all listeners are cancelled. Previously just cancelled the sub, which would not allow new subs, as there is a null check before assigning a new sub. Fixes [iOS]GameAuth.isSignedInnot working after user cancel theGameAuth.signIn()#158.[BUG FIX] Set the cached player to
nullwhen an error occurs across theplayerstream.[QoL] Make the
playerstreamdistinct, meaning that current listeners do not receive duplicate data when new listeners are added or legacy methods are called.[QoL] Bump iOS deployment target to 12.4 which provides better feedback to the dev when building for iOS, as it is now necessary due to the use of
gamePlayerID(playerIDis deprecated). It will also be necessary when upgrading from other deprecated GameKit methods.[QoL] Update some information in the podspec file to match the version number and provide links to the GitHub.