Skip to content

Fixes delay in some results after sign in#189

Merged
Abedalkareem merged 1 commit intodevelopfrom
bugfix/back-compat
May 15, 2025
Merged

Fixes delay in some results after sign in#189
Abedalkareem merged 1 commit intodevelopfrom
bugfix/back-compat

Conversation

@theLee3
Copy link
Copy Markdown
Collaborator

@theLee3 theLee3 commented Mar 31, 2025

Certain legacy implementations may see a delay in sign-in status and functionality directly after successful sign-in. This update resolves that issue by only using the "cached" player value if a stream is currently open. Otherwise, it only uses the new value transmitted when a new channel stream is created.

Fixes #188

@theLee3 theLee3 force-pushed the bugfix/back-compat branch from 036cc13 to 0c84e17 Compare April 1, 2025 17:50
@PacifistaBot
Copy link
Copy Markdown
Collaborator

PacifistaBot commented Apr 1, 2025

Fails
🚫 Flutter analyzer failed. Please fix the issues reported by the analyzer. Error: Command failed: flutter analyze 1 issue found. (ran in 7.5s)
Warnings
⚠️

Please update the CHANGELOG.md file.

⚠️

Please update the documentation in the docs/ folder.

Generated by 🚫 dangerJS against dcdada6

@theLee3 theLee3 force-pushed the bugfix/back-compat branch from 0c84e17 to ff3163f Compare April 1, 2025 17:51
@wantroba
Copy link
Copy Markdown

@theLee3 any idea when this will be published on pub.dev? We are facing some issues in some apps because of this error

@theLee3
Copy link
Copy Markdown
Collaborator Author

theLee3 commented Apr 30, 2025

@Abedalkareem Can we get this patch published quickly?

@theLee3 theLee3 requested a review from Abedalkareem April 30, 2025 16:21
@gnarhard
Copy link
Copy Markdown

@Abedalkareem What's the hold up on publishing this patch?

@Abedalkareem Abedalkareem merged commit d2ac2ab into develop May 15, 2025
1 of 2 checks passed
@Abedalkareem
Copy link
Copy Markdown
Owner

Sorry for the delay, I'm publishing it now

@gnarhard
Copy link
Copy Markdown

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On fresh install, first authentication fails, but will succeed on the second app open.

5 participants