Add EspLog to log through ESP-IDF on ESP32 devices #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me. Could you please fix the formatting and rebase? |
docwilco
force-pushed
the
esp-idf-logging
branch
from
0284c3d to
0b659ca
Compare
Contributor
Author
|
I rebased this on the commit in #162, so don't start the workflow until that's merged. Once that PR is in, this should be able to fast-forward into |
Contributor
|
Thanks! Could you rebase once onto master, please. |
This still needs to be manually enabled in Config.hpp, like all the other Log variants.
docwilco
force-pushed
the
esp-idf-logging
branch
from
0b659ca to
d309c47
Compare
Contributor
Author
|
Done! |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs to be manually enabled in Config.hpp, like all the other Log variants.