Remove instruction to mark maxpat files as text #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that when explicitly marking a file type as text, git will enforce line endings on checkout more strictly. This can lead to .maxpat files showing up as having whitespace changes even after doing a `git reset —hard` (which checks out files again). Also removes marking the other files as binary since that is not actually needed either; git will automatically detect them as binary.
MattijsKneppers
force-pushed
the
mkp-remove-marking-as-text
branch
from
02c75b0 to
d59dd81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when explicitly marking a file type as text, git will enforce line endings on checkout more strictly. This can lead to .maxpat files showing up as having whitespace changes even after doing a
git reset —hard(which checks out files again).Also removes marking the other files as binary since that is not actually needed either; git will automatically detect them as binary.