Skip to content

chore: deduplicate default http transport initialization#411

Open
Ocheretovich wants to merge 1 commit intoAbstract-Foundation:mainfrom
Ocheretovich:main
Open

chore: deduplicate default http transport initialization#411
Ocheretovich wants to merge 1 commit intoAbstract-Foundation:mainfrom
Ocheretovich:main

Conversation

@Ocheretovich
Copy link
Copy Markdown

@Ocheretovich Ocheretovich commented Mar 16, 2026

Remove duplicated fallback HTTP transport initialization


PR-Codex overview

This PR focuses on refactoring the handling of the transport variable in the eip6963emitter.ts file, improving code clarity and reducing redundancy.

Detailed summary

  • Introduces a new constant resolvedTransport to handle the transport variable.
  • Replaces the inline transport logic with resolvedTransport in the privyProvider configuration.
  • Updates the abstractProvider to use resolvedTransport instead of repeating the transport logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 16, 2026

⚠️ No Changeset found

Latest commit: 44a6f16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 16, 2026

PR Summary

Low Risk
Low risk refactor that centralizes the fallback http({ batch: true }) transport into a single resolvedTransport value; behavior should remain unchanged aside from reducing duplication.

Overview
Deduplicates the default Viem http transport fallback in announceProvider by introducing a single resolvedTransport and reusing it for both Privy transports configuration and transformEIP1193Provider.

This is a small refactor intended to keep transport selection consistent and avoid repeating the same initialization logic.

Written by Cursor Bugbot for commit 44a6f16. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant