[Aikido] Fix security issue in hono via minor version upgrade from 4.11.8 to 4.12.7#422
Conversation
PR SummaryMedium Risk Overview This is a minor-version bump intended to pull in upstream fixes (e.g., authorization bypass and injection/prototype-pollution issues) without changing application code. Written by Cursor Bugbot for commit efe461b. This will update automatically on new commits. Configure here. |
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "on-headers@<1.1.0": ">=1.1.0", | ||
| "tmp@<=0.2.3": ">=0.2.4" | ||
| "tmp@<=0.2.3": ">=0.2.4", | ||
| "hono@<=4.12.7": "4.12.7" |
There was a problem hiding this comment.
Override pins exact version instead of minimum range
Low Severity
The hono override uses an exact version pin ("4.12.7") while all other overrides in this file use a minimum range (">=X.Y.Z"). For example, tmp uses ">=0.2.4". Pinning to "4.12.7" means future hono patch releases (e.g., 4.12.8) with additional security or bug fixes won't be picked up by the override — the override would need to be manually updated. Using ">=4.12.7" would match the existing convention and allow automatic adoption of future patches.
79f7ae7 to
efe461b
Compare


Upgrade Hono to fix critical authorization bypass via URL decoding mismatch in static file serving, plus medium-severity SSE/cookie injection and prototype pollution vulnerabilities.
✅ 5 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
parseBody({ dot: true })where specially crafted form field names like__proto__.xcreate objects with__proto__properties, potentially enabling prototype pollution if merged unsafely into other objects.basicAuthandbearerAuthmiddlewares used non-timing-safe string comparison for hash validation, potentially allowing timing-based analysis attacks. The vulnerability has been fixed by implementing constant-time comparison to prevent early termination.🔗 Related Tasks
PR-Codex overview
This PR focuses on updating dependencies in the
package.jsonandpnpm-lock.yamlfiles, ensuring compatibility and incorporating new versions for better performance and security.Detailed summary
tmpdependency version constraint inpackage.json.honoversion4.12.7topackage.jsonandpnpm-lock.yaml.@privy-io/cross-app-connectand@wagmi/coreto includebabel-plugin-macrosinpnpm-lock.yaml.