[Aikido] Fix 11 security issues in hono, socket.io-parser, axios and 3 more#426
[Aikido] Fix 11 security issues in hono, socket.io-parser, axios and 3 more#426aikido-autofix[bot] wants to merge 1 commit intomainfrom
Conversation
|
PR SummaryLow Risk Overview Also updates Written by Cursor Bugbot for commit 8aeb0fa. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "socket.io-parser@<=4.2.6": "4.2.6", | ||
| "axios@<=1.13.5": "1.13.5", | ||
| "h3@<=1.15.9": "1.15.9", | ||
| "lodash@<=4.17.23": "4.17.23" |
There was a problem hiding this comment.
Overrides pin exact versions instead of minimum ranges
Medium Severity
The five new pnpm overrides use exact version pins (e.g., "hono@<=4.12.7": "4.12.7") instead of >= range targets (e.g., ">=4.12.7"), which all existing overrides in this file consistently use. Exact pins prevent transitive dependencies from automatically resolving to newer patch versions that may contain additional security fixes. For instance, if hono 4.12.8 ships a future CVE fix, this override would still force resolution to 4.12.7. Given that this PR is specifically about security, these overrides undermine their own purpose over time.
| "react": ">=18.3.1", | ||
| "react-dom": ">=18.3.1", | ||
| "thirdweb": "^5.68.0", | ||
| "thirdweb": "5.93.5-nightly-b51157c0ff17e9535029fc8790cfa8538d1c995f-20250326000337", |
There was a problem hiding this comment.
Nightly thirdweb build pinned in devDependencies
Medium Severity
The thirdweb devDependency was changed from ^5.68.0 to a nightly build (5.93.5-nightly-...). Nightly builds are typically ephemeral and may be unpublished from npm, which would break pnpm install for all contributors. This change appears unrelated to the security-fix purpose of this PR and looks like it was accidentally included from local testing.


Upgrade dependencies to fix authorization bypass in static file serving, memory exhaustion in WebSocket parsing, DoS via malformed config objects, and SSE injection attacks.
✅ 11 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
parseBody({ dot: true })where specially crafted form field names like__proto__.xcreate objects with__proto__properties, potentially enabling prototype pollution if merged unsafely into other objects.basicAuthandbearerAuthmiddlewares used non-timing-safe string comparison for hash validation, potentially allowing timing-based analysis attacks. The vulnerability has been fixed by implementing constant-time comparison to prevent early termination.\r) characters in data and comment fields, allowing attackers to inject arbitrary SSE events, spoof event types, and split single push() calls into multiple browser-parsed events. This bypasses a prior fix that only addressed newline (\n) injection.🔗 Related Tasks
PR-Codex overview
This PR focuses on updating various dependencies in the
package.jsonfiles and making adjustments to thepnpm-lock.yamlfile to reflect these changes. It also includes modifications to thelint-stagedconfiguration.Detailed summary
packageManagerinpackage.json.lint-stagedconfiguration format.hono,socket.io-parser,axios,h3,lodash.thirdweband@tanstack/react-query.typesVersionsformat inpackages/agw-react/package.json.filesarray inpackages/agw-react/package.json.pnpm-lock.yamlfor various packages.