Skip to content

Add ABI tags to the built Python modules #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cary-ilm merged 3 commits into from
Nov 25, 2025
Merged

Add ABI tags to the built Python modules #531

cary-ilm merged 3 commits into from
Nov 25, 2025

Conversation

@Andrej730
Copy link
Contributor

@Andrej730 Andrej730 commented Nov 18, 2025 •
edited
Loading

E.g. imath.pyd -> imath.cp39-win_amd64.pyd or imathnumpy -> imathnumpy.cp39-win_amd64.pyd.

Similar to how pybind11_add_module does it automatically for pybindimath.cp39-win_amd64.pyd.

@Andrej730 Andrej730 force-pushed the python_modules_abi branch 3 times, most recently from 0efe4b8 to 8516d96 Compare November 18, 2025 18:45
@Andrej730
Add ABI tags to the built Python modules
403d76b 
E.g. `imath.pyd` -> `imath.cp39-win_amd64.pyd` or `imathnumpy` -> `imathnumpy.cp39-win_amd64.pyd.

Similar to how `pybind11_add_module` does it automatically for `pybindimath.cp39-win_amd64.pyd`.

Signed-off-by: Andrej730 <azhilenkov@gmail.com>
@Andrej730
Copy link
Contributor Author

Andrej730 commented Nov 18, 2025 •
edited
Loading

Ahh, Python3_SOABI was introduced in cmake 3.17.. https://cmake.org/cmake/help/latest/module/FindPython3.html
I guess it will require to get sysconfig.get_config_var('EXT_SUFFIX') from Python3_EXECUTABLE, will look into it.

@Andrej730
Copy link
Contributor Author

Andrej730 commented Nov 19, 2025

Should be good.

@Andrej730
Copy link
Contributor Author

Andrej730 commented Nov 22, 2025

@cary-ilm Hi! Can you please take a look?

@cary-ilm
Copy link
Member

cary-ilm commented Nov 23, 2025

This looks fine, thanks. The DCO ("Developer Certificate of Origin") check is failing, because the Academy Software Foundation policy is to require signed commits, commits created with the "-s" option to add the "signed off by" line. Unfortunately, you can't correct this with a subsequent commit, you need to amend the existing commits. I would recommend squashing the three commits into a single commit ("git rebase -i HEAD~3"), then "git commit -s --amend --no-edit". Then "git push --force".

@Andrej730
Fix indentation
3220a9d 
Signed-off-by: Andrej730 <azhilenkov@gmail.com>
@Andrej730
Support cmake 3.14
5faf994 
Signed-off-by: Andrej730 <azhilenkov@gmail.com>
@Andrej730
Copy link
Contributor Author

Andrej730 commented Nov 24, 2025

Thanks, I keep forgeting about signing the commits. Fixed.

cary-ilm
cary-ilm approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cary-ilm cary-ilm merged commit 4662bbc into AcademySoftwareFoundation:main Nov 25, 2025
34 checks passed
@Andrej730 Andrej730 deleted the python_modules_abi branch November 25, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andrej730 @cary-ilm