Add flake node implementations#2676
Add flake node implementations#2676jstone-lucasfilm merged 16 commits intoAcademySoftwareFoundation:mainfrom
Conversation
|
Apologies for the delay in reviewing this, @msuzuki-nvidia, and I'd like to return community focus to this PR. Would you mind addressing the merge conflicts, so that we can begin testing this in the latest MaterialX codebase? |
Signed-off-by: Masuo Suzuki <153872239+msuzuki-nvidia@users.noreply.github.com>
|
@jstone-lucasfilm Resolved. I hope we can get reviews on PRs more regularly before they expire. |
|
That's my aim, @msuzuki-nvidia, to gather sufficient community focus on this PR that it can be reviewed and merged. Bringing it up for our next MaterialX TSC seems like a good first step along that path. |
jstone-lucasfilm
requested review from
crydalch,
dbsmythe and
niklasharrysson
|
Added a small note on the spec doc, but it otherwise looks good. No further comments from us since looking at the proposal in October, this will be welcome/exciting! Sorry we didn't transfer our thumbs-up to the PR when it came online in November. Thanks @msuzuki-nvidia ! |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
|
are there any more comments? Is this good to merge @jstone-lucasfilm |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
This looks ready to merge, @msuzuki-nvidia and @fpliu.
Thanks for putting this great proposal together, @msuzuki-nvidia, including both the interface design and initial GLSL/MDL implementations.
jstone-lucasfilm
merged commit 68a94a2
into
AcademySoftwareFoundation:main
5 participants
This PR adds GLSL and MDL implementations for the flake nodes proposed in #2609.
Nodes to add:
<flake2d><flake3d>