Consolidate edge creation in Graph Editor#2793
Open
jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
Consolidate edge creation in Graph Editor#2793jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This changelist consolidates edge creation logic in the MaterialX Graph Editor, adding shared helper methods and merging parallel code paths. The following specific changes are included: - Add a `findUpstreamNode` helper method to handle the resolution of upstream connections for an input. - Add a `createEdgeForOutput` helper method to handle the creation of edges from output elements to their connected upstream nodes. - Unify edge creation in `buildUiBaseGraph` into a single loop over all graph nodes, replacing separate loops for nodegraphs and surface shader nodes. - Add missing edge creation and render material updates for document-scope outputs (addresses issue AcademySoftwareFoundation#2294).
Member
Author
|
Highlighting the fix for #2294, here's a new render of the 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist consolidates edge creation logic in the MaterialX Graph Editor, adding shared helper methods and merging parallel code paths. The following specific changes are included:
findUpstreamNodehelper method to handle the resolution of upstream connections for an input.createEdgeForOutputhelper method to handle the creation of edges from output elements to their connected upstream nodes.buildUiBaseGraphinto a single loop over all graph nodes, replacing separate loops for nodegraphs and surface shader nodes.