Add missing initialization on document load in Graph Editor#2795
Merged
jstone-lucasfilm merged 1 commit intoAcademySoftwareFoundation:mainfrom Mar 2, 2026
Merged
Conversation
_currUiNode may hold onto to last selection. _currRenderNode should also be cleared to prevent trying to render last node. (should also remove extra render when load and select nodegraph).
Contributor
Author
|
@jstone-lucasfilm . Maybe this is due to recent refactoring ? Anyways this should make it safe in general now as no data members should hold on to previous MTLX data. |
jstone-lucasfilm
approved these changes
Mar 2, 2026
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, @kwokcb, and this looks good to me.
Going forward, we should likely refactor the new/load/reload helper methods in the Graph Editor to use clearGraph consistently, but your proposal is a good step for now.
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 6ee8ffa
into
AcademySoftwareFoundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes: #2794.
There are references to the previous MaterialX documents on file load
Change
_currUiNode: Would hold onto to last selection if any. This seems the root cause of the property editor crash._currRenderNode: Should also be cleared to prevent trying to render last node. This seems to also fix having extra renders when load and select nodegraph.