Skip to content

Align UsdPreviewSurface opacity with upcoming specification #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jstone-lucasfilm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Align UsdPreviewSurface opacity with upcoming specification #2796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions libraries/bxdf/usd_preview_surface.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,17 @@
<input name="normal" type="vector3" nodename="surface_normal" />
<input name="scatter_mode" type="string" value="T" />
</dielectric_bsdf>
<ifgreater name="transmission_mix_amount" type="float">
<ifgreater name="transmission_mix_amount_transparent" type="float">
<input name="value1" type="float" interfacename="opacityThreshold" />
<input name="value2" type="float" value="0" />
<input name="in1" type="float" value="1" />
<input name="in2" type="float" interfacename="opacity" />
</ifgreater>
<switch name="transmission_mix_amount" type="float">
<input name="in1" type="float" nodename="transmission_mix_amount_transparent" />
<input name="in2" type="float" value="1.0" />
<input name="which" type="integer" interfacename="opacityMode" />
</switch>
<mix name="transmission_mix" type="BSDF">
<input name="fg" type="BSDF" nodename="diffuse_bsdf" />
<input name="bg" type="BSDF" nodename="transmission_bsdf" />
Expand Down Expand Up @@ -285,12 +290,12 @@
<input name="in1" type="float" value="1" />
<input name="in2" type="float" value="0" />
</ifgreatereq>
<ifequal name="opacity_presence" type="float">
<input name="value1" type="float" interfacename="opacity" />
<input name="value2" type="float" value="0.0" />
<input name="in1" type="float" value="0.0" />
<input name="in2" type="float" nodename="cutout_opacity" />
</ifequal>
<ifgreater name="opacity_presence" type="float">
<input name="value1" type="float" interfacename="opacityThreshold" />
<input name="value2" type="float" value="0" />
<input name="in1" type="float" nodename="cutout_opacity" />
<input name="in2" type="float" interfacename="opacity" />
</ifgreater>
<switch name="opacity_switch" type="float">
<input name="in1" type="float" nodename="cutout_opacity" />
<input name="in2" type="float" nodename="opacity_presence" />
Expand Down