Skip to content

fix: iam mock subject not empty when it is non user token #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arifinab wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: iam mock subject not empty when it is non user token #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions mockclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const (
MockForbidden = "forbidden"
MockAudience = "http://example.com"
MockSecret = "mocksecret"
ClientToken = "mock_token"
)

// MockClient define mock oauth client config
Expand All @@ -48,7 +49,7 @@ func (client *MockClient) ClientTokenGrant(opts ...Option) error {

// ClientToken returns client access token
func (client *MockClient) ClientToken(opts ...Option) string {
return "mock_token"
return ClientToken
}

// StartLocalValidation starts goroutines to refresh JWK and revocation list periodically
Expand Down Expand Up @@ -85,6 +86,11 @@ func (client *MockClient) ValidateAndParseClaims(accessToken string, opts ...Opt

claims.Audience = append(claims.Audience, MockAudience)

// non user token will has empty Subject
if accessToken == ClientToken {
claims.Subject = ""
}

switch accessToken {
case MockUnauthorized:
return nil, errUnauthorized
Expand All @@ -105,9 +111,12 @@ func (client *MockClient) ValidateAndParseClaims(accessToken string, opts ...Opt

// ValidatePermission validates if an access token has right for a specific permission
// requiredPermission: permission to access resource, example:
// {Resource: "NAMESPACE:{namespace}:USER:{userId}", Action: 2}
//
// {Resource: "NAMESPACE:{namespace}:USER:{userId}", Action: 2}
//
// permissionResources: resource string to replace the `{}` placeholder in
// `requiredPermission`, example: p["{namespace}"] = "accelbyte"
//
// `requiredPermission`, example: p["{namespace}"] = "accelbyte"
func (client *MockClient) ValidatePermission(claims *JWTClaims,
requiredPermission Permission, permissionResources map[string]string, opts ...Option) (bool, error) {
if claims.Permissions[0].Resource == MockForbidden {
Expand Down