Fix signature + response handling for DELETE requests#24
Merged
Conversation
Two bugs prevented `WebhooksService.DeleteAsync` from working against the real API: 1. DELETE fell through to the "body payload" branch in `MakeRequestAsync` and signed an empty string with no `sig_payload` query param, so the server returned 401. Extend the GET/POST-no-body signing path to also cover DELETE so the resource id is attached as `sig_payload`. 2. `MakeRequestAsync` always tried to deserialize the response body, which for a 204/empty DELETE response threw JsonException. Return `default(T)` when the body is empty. Adds a regression test asserting DELETE requests include `sig_payload=`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs prevented
WebhooksService.DeleteAsyncfrom working against the real API:DELETE fell through to the "body payload" branch in
MakeRequestAsyncand signed an empty string with nosig_payloadquery param, so the server returned 401. Extend the GET/POST-no-body signing path to also cover DELETE so the resource id is attached assig_payload.MakeRequestAsyncalways tried to deserialize the response body, which for a 204/empty DELETE response threw JsonException. Returndefault(T)when the body is empty.Adds a regression test asserting DELETE requests include
sig_payload=.