Skip to content

ADG-414 Improve code quality with github actions #415

Closed
rudigier wants to merge 21 commits intomainfrom
feature/code_quality
Closed

ADG-414 Improve code quality with github actions #415
rudigier wants to merge 21 commits intomainfrom
feature/code_quality

Conversation

@rudigier
Copy link
Collaborator

@rudigier rudigier commented Jun 29, 2023

No description provided.

@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for accessibility-developer-guide ready!

Name Link
🔨 Latest commit 790ae4a
🔍 Latest deploy log https://app.netlify.com/sites/accessibility-developer-guide/deploys/679b44e93027da000837ecbe
😎 Deploy Preview https://deploy-preview-415--accessibility-developer-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rudigier rudigier changed the title ADG-414 Improve code quality with github actions tests for each PR and main pushes ADG-414 Improve code quality with github actions Jun 29, 2023
@rudigier rudigier requested a review from backflip June 29, 2023 09:09
@rudigier rudigier mentioned this pull request Jun 29, 2023
Closed
backflip
backflip reviewed Jun 29, 2023
View reviewed changes
.github/workflows/codeQuality.yml Outdated
on:
pull_request:
push:
branches: [master]
Copy link
Collaborator

@backflip backflip Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rudigier, shouldn't this be main?

backflip
backflip reviewed Jun 29, 2023
View reviewed changes
.github/workflows/codeQuality.yml Outdated
@@ -0,0 +1,29 @@
#
# linter and dependancy cruiser tests
Copy link
Collaborator

@backflip backflip Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is dependancy cruiser?

@backflip
Copy link
Collaborator

backflip commented Jun 29, 2023

Wow, that was quick!

Could we run the fix jobs and commit the changes in this workflow? I don't see any upside in still having to do this locally.

@NicSR
Copy link
Contributor

NicSR commented Jun 20, 2024

@backflip: pr bitte nochmals reviewen

@rudigier
Copy link
Collaborator Author

rudigier commented Jan 30, 2025

@backflip Switched to checking instead of auto-fixing to avoid unexpected commits in PRs. Developers should review and apply fixes manually.

@rudigier rudigier assigned rudigier and backflip and unassigned rudigier Jan 30, 2025
@backflip
Copy link
Collaborator

backflip commented Feb 3, 2025

@rudigier, hm, but isn't this worse than the current setup? Assuming I want to contribute to the project, I will only be informed after opening a PR that I need to reformat some files. With the current setup this already happens before committing. I would prefer to close this PR if we cannot auto-fix. WDYT?

@rudigier rudigier closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@backflip backflip backflip left review comments

Assignees

@backflip backflip

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rudigier @backflip @NicSR