Skip to content

ADG-469 - Tablist aria labels#470

Open
rudigier wants to merge 4 commits intomainfrom
feature/469-tablist
Open

ADG-469 - Tablist aria labels#470
rudigier wants to merge 4 commits intomainfrom
feature/469-tablist

Conversation

@rudigier
Copy link
Collaborator

@rudigier rudigier commented Feb 5, 2026

No description provided.

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for accessibility-developer-guide ready!

Name Link
🔨 Latest commit c24dde0
🔍 Latest deploy log https://app.netlify.com/projects/accessibility-developer-guide/deploys/69a981dd11a81c0007409175
😎 Deploy Preview https://deploy-preview-470--accessibility-developer-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@RA11y1 RA11y1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions of used software

Firefox 147.0.1
Chrome 144.0.7559.59
NVDA 2025.3.2.535.88
JAWS 2026.2512.50

Code example

Tested with both screen readers in each browser. Behavior is robust across all combinations.

Changes in Text

Maybe one small thing to add here: Knowledge - Widgets
Under "The priciple" you state "Enhance with ARIA when semantic HTML alone isn't sufficient". Adding a caveat might be considered: attention should be paid on robustness of roles and attributes used , as browsers and screen readers still differ quite a lot in how certain aria roles and attributes are interpreted.

Otherwise I have nothing to add, thanks for implementing @rudigier !

@rudigier
Copy link
Collaborator Author

rudigier commented Mar 5, 2026

Added the mentioned hint.

@RA11y1
Copy link
Collaborator

RA11y1 commented Mar 5, 2026

thank you @rudigier looks great!
Just noticed one last thing: the section when to use standard html promotes using form controls. Since the section below (best practices) already states that one should start with plain HTML I think we could just remove the section when to use standard html, what do you think?

@rudigier rudigier assigned RA11y1 and unassigned rudigier Mar 5, 2026
@rudigier
Copy link
Collaborator Author

rudigier commented Mar 5, 2026

@RA11y1 Makes sense, just removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants