Add compatibility with psr/container 2.0#51
Open
chrisemerson wants to merge 1 commit intoAcclimateContainer:2.xfrom
Open
Add compatibility with psr/container 2.0#51chrisemerson wants to merge 1 commit intoAcclimateContainer:2.xfrom
chrisemerson wants to merge 1 commit intoAcclimateContainer:2.xfrom
Conversation
|
This is exactly the issue I've been facing. This would be perfect! |
Author
|
If this package is no longer maintained can it be marked as abandoned on packagist? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding return types to existing implementations will still be compatible with psr/container 1.0 also because of PHP's covariance rules, while adding compatibility with psr/container 2.0. Leaving off parameter types similarly will maintain compatibility with both as per PHP's contravariance rules.