Skip to content

Conversation

@lazd
Copy link

@lazd lazd commented Nov 2, 2022

This PR fixes instances where attribute values were quoted with single quotes. Netscape 1.12 doesn't like this, and this was resulting in all links to be broken.

I imagine this originally happened because of PHP's nice variable interpolation feature when double quotes are used (i.e. "Hi my name is $name"), but most instances used the string concatenation operator (.), so I just kept them as-is instead of trying to get fancy and escape chars.

I couldn't test this as I don't have a PHP environment running locally, but it should work!

Fixes #5

@lukecyca
Copy link

This fix looks good to me. @ActionRetro are you able to merge this and deploy to frogfind.com?

@lazd
Copy link
Author

lazd commented May 13, 2023

Let's get this merged!

@jibsaram
Copy link
Contributor

@lazd This branch has a few small conflicts after #21 got merged, but that's only because this branch includes some fixes in files that now no longer exist (left-over files of the 68k.news project that were in here too). If you were to pull in the latest from main and accept that these files have been deleted now, this branch should be A-OK for getting merged again when Mister ActionRetro has a chance to take a peek!

@lazd
Copy link
Author

lazd commented Aug 15, 2023

Thanks @jibsaramnim, it's up to date now!

Copy link
Contributor

@jibsaram jibsaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ActionRetro For what it's worth, I took a look through this and it's looking great. A nice small PR that you might be able to squeeze in for the next release you might be planning on? Thank you so much for all that you do! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search result links don't work properly on Netscape 1.12 for MacOS

3 participants