Improve readability of code by using if expression#6
Open
pjljvandelaar wants to merge 1 commit intoAda-Audio:mainfrom
Open
Improve readability of code by using if expression#6pjljvandelaar wants to merge 1 commit intoAda-Audio:mainfrom
pjljvandelaar wants to merge 1 commit intoAda-Audio:mainfrom
Conversation
Author
|
If this merge is accepted, |
Collaborator
|
Sorry for the delay: I'll take a look into your changes as soon as I have some spare time. Feel free to perform others checks. The only thing I'd like to ask you, though, is to avoid creating an issue and a pull request at the same time: creating a pull request alone is more than sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is simplified by using if expressions (and simplifying that when possible).
This pull requests solves #5
Problem detected and solved by Rejuvenation-Ada crate
