Open
Conversation
lebaongoc
reviewed
Mar 1, 2019
| decimal = 0 | ||
| binary_array.length.times do |i| | ||
| decimal += binary_array[i] * 2 ** (7 - i) | ||
| end |
There was a problem hiding this comment.
Overall, I think your code looks great! It's very concise! One comment that I have is on line 11, in the case where you would want to scale this program to intake binary number greater than 8 numbers, you might want to modify exponent of the 2 (the 7-i part). Perhaps setting the binary_array.length = n and the exponent would be (n-i). For example if the binary_array.length = 9 then the exponent would be (9-i) Let me know if this does not make sense :)
Collaborator
There was a problem hiding this comment.
That's great feedback! To address this feedback, how about leveraging the length of the array? Instead of 7, use binary_array.length - 1.
Collaborator
|
Nice work! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary and Decimal
Congratulations! You're submitting your assignment.