Open
Conversation
ChubbyCub
reviewed
Mar 1, 2019
| def binary_to_decimal(binary_array) | ||
| raise NotImplementedError | ||
| decimal = 0 | ||
| 8.times do |i| |
There was a problem hiding this comment.
Good job with the do ... loop. Can you think of a way to generalize the algorithm so that it works for n bits?
ChubbyCub
reviewed
Mar 1, 2019
| raise NotImplementedError | ||
| decimal = 0 | ||
| 8.times do |i| | ||
| decimal += binary_array[i] * 2 ** (7 - i) |
There was a problem hiding this comment.
Good job with using the math operator **. Can you think of a faster way to perform this without having to use the ** operation? Your code currently requires recalculating 2 to the power of n (number of bits) at every iteration.
Collaborator
|
Nice work! Think about the comments and questions that your code review buddy shared with you, and discuss them further with your buddy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary and Decimal
Congratulations! You're submitting your assignment.