Open
Conversation
Media RankerWhat We're Looking For
|
droberts-sea
reviewed
May 8, 2019
| root "homepages#index" | ||
|
|
||
| resources :works | ||
| resources :users, only: [:index, :show] |
There was a problem hiding this comment.
Good work only generating the routes you need here.
| belongs_to :user | ||
|
|
||
| validates :user, uniqueness: {scope: :work, | ||
| message: "User can only vote on this work one time"} |
There was a problem hiding this comment.
Good work getting this tricky uniqueness scope figured out!
|
|
||
| def self.get_top_ten(category) | ||
| return self.sorted_works(category)[0...10] | ||
| end |
There was a problem hiding this comment.
I love the way the methods in this file build on each other, each providing a small bit of functionality. This is an excellent example of functional decomposition.
| </tr> | ||
| <% Work.sorted_works(category).each do |work| %> | ||
| <tr> | ||
| <td><%= work.votes.count %></td> |
There was a problem hiding this comment.
I'm not a huge fan of calling a model method directly from the view like this - would it be possible to "tee up" this data in the controller?
|
|
||
| describe "login" do | ||
| it "will login user" do | ||
| post login_path, params: @login_data |
There was a problem hiding this comment.
You have two tests here, but these are only covering one behavior mode for this controller action (logging in an existing user). I would probably combine these into one.
However, there are a couple of behavior modes you're not covering:
- Logging in a new user (should create that user)
- Attempting to log in with an invalid username (e.g. empty string) (should fail)
| describe "logout" do | ||
| it "will logout user" do | ||
| perform_login | ||
| post logout_path |
There was a problem hiding this comment.
What happens if no one is logged in?
| describe "upvote" do | ||
| it "disallows guest users voting if they have not logged in" do | ||
| user = users(:kelly) | ||
| work = works(:amelie) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?