Ports - Sopheary by sophearychiv · Pull Request #28 · Ada-C11/hotel

sophearychiv · 2019-03-18T07:02:40Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	It was hard at first to come up with composition relationships between classes. I was not sure which classes should contain the others and which ones should be contained. It got clearer as I started the actual coding.
What was a design decision you made that changed over time over the project?	First, I had a superclass from which Reservation and Room classes would inherit from, but then after giving it a second thought, I decided that having a superclass was not necessary since the classes Room and Reservation do not have many similar behaviors or state.
What was a concept you gained clarity on, or a learning that you'd like to share?	When and how to create an instance from a class. For example, I created an instance of the class Reserve to store a collection of reservations that I can later on query to check available rooms for a given date range.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	A nominal test I wrote was a test to check if the method .reserve can reserve an available room and adds the new reservation to the list of reservations. It's a nominal case because it behaves as expected.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	An edge case I wrote was the one that tests that the .reserve method cannot reserve unavailable rooms. That it occurs at an extreme case (when the room is unavailable) makes it an edge case.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I didn't do well at first. It took me many attempts to start feeling more accustomed to it. I felt like it's kind of a waste of time to go through the process of writing the pseudocode before writing tests and then code, though I know that it simplified my thoughts and design and helped me break down the problems.

…lock

…other block

CheezItMan · 2019-03-24T23:33:48Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and good commit messages
Answer comprehension questions	Check, I'm sorry writing pseudocode was such a tough exercise for you.
Design
Each class is responsible for a single piece of the program	For the most part, see my inline comments about your manager class.
Classes are loosely coupled	Check
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Check
Wave 3
Create a block of rooms	Check
Check if a block has rooms	Check
Reserve a room from a block	Check
Test coverage	100%
Fundamentals
Names variables, classes and modules appropriately	For the most part, see my inline comments
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Check
Understands the differences between class and instance methods	See my inline notes especially about your `DateRange` class.
Appropriately uses iterators and `Enumerable` methods	Check
Appropriately writes and utilizes classes	Check
Appropriately utilizes modules as a namespace	Check
Wrap Up
There is a refactors.txt file	Check
The file provides a roadmap to future changes	Check
Additional Feedback	Well done, this was a tough project and you got a design working. I do think your `DateRange` class is very underused and could either be folded into `Reservation` or made into a useful class where each `Reservation` and `Block` would have-a `DateRange` and could use it to detect overlaps between `Reservations` and `Blocks`. Let me know if you have questions.

CheezItMan · 2019-03-24T22:52:50Z

@@ -0,0 +1,29 @@
+require "spec_helper"


This should be require_relative

CheezItMan · 2019-03-24T22:54:52Z

+    end
+
+    def self.load_all
+      return @reservations || []


You're trying to use in instance variable in a class method. That doesn't make sense.

This method looks like it should be reading from the CSV file and returning a list of Reservations.

CheezItMan · 2019-03-24T22:58:02Z

+    def initialize(check_in_date, check_out_date)
+      self.class.validate_date(check_in_date)
+      self.class.validate_date(check_out_date)
+      validate_date_range(check_in_date, check_out_date)


You're not saving check_in_date or check_out_date in instance variables here... so why have the class.

I think you're missing

@start_date = check_in_date @end_date = check_out_date

On the other hand if you don't' want to make instances of DateRange I suggest making it a module and have no initialize method.

CheezItMan · 2019-03-24T23:01:50Z

+    end
+
+    # I can access the list of reservations for a specific date, so that I can track reservations by date
+    def list_reservations(date:)


CheezItMan · 2019-03-24T23:02:34Z

+    end
+
+    # I can get the total cost for a given reservation
+    def total_cost(reservation_id:)


I suggest the cost of a reservation is best served in the Reservation class. It seems like your manger class is doing too many jobs.

CheezItMan · 2019-03-24T23:23:56Z

+                                       check_in_date: "2019-03-10",
+                                       check_out_date: "2019-03-15",
+                                       discount_rate: 0.10)
+      expect {


You should also have edge-case tests, like reserving a room on the same day a previous reservation ends, and on the same day one begins.

You should also test reserving two different rooms on the same dates.

CheezItMan · 2019-03-24T23:24:21Z

+                                  check_in_date: "2019-04-12",
+                                  check_out_date: "2019-04-15")
+      expect(reservation_manager.list_reservations(date: "2019-03-14").length).must_equal 2
+      expect(reservation_manager.list_reservations(date: "2019-04-14").length).must_equal 1


You should also check the values inside those arrays.

CheezItMan · 2019-03-24T23:25:27Z

+      reserve_04_15_04_20
+      expect(reservation_manager.find_available_rooms(check_in_date: "2019-03-20", check_out_date: "2019-03-22").length).must_equal 20
+      expect(reservation_manager.find_available_rooms(check_in_date: "2019-04-17", check_out_date: "2019-04-19").length).must_equal 19
+      expect(reservation_manager.find_available_rooms(check_in_date: "2019-03-10", check_out_date: "2019-04-19").length).must_equal 18


I would also check that at least one of the expected available rooms is available and that a room that is booked is not listed as available.

CheezItMan · 2019-03-24T23:26:07Z

+      expect(reservation_manager.find_available_rooms(check_in_date: "2019-03-08", check_out_date: "2019-03-22").length).must_equal 19
+    end
+
+    it "returns the right number of rooms when check_in_date and check_out_date range is within reserved rate range " do


The above are good tests.

CheezItMan · 2019-03-24T23:27:12Z

+    end
+  end
+
+  describe "validate_id method" do


validate_id seems like it should be a private helper method and thus not tested directly.

Sopheary Chiv added 30 commits March 11, 2019 17:01

fixed Guardfile

226ccc6

created tests for room_manager

117db94

created room_manager

929b9e3

created tests for room class

74aba39

created room class

52c9021

added tests for record.rb

57fea69

added Record class

4ddfb67

added tests for Reservation class

c15aa58

added Reservation class

bd1c0cc

added access to the list of all of the rooms in the hotel

d37e345

added the ability to reserve a room for a given date range

dd01971

added the feature to get list of reservations for a specific date

28c7a8d

added total cost for a given reservation

81af9b9

removed inheritance from Record

12967f1

validated date range

85fd313

fixed errors on Reservation

6af6eee

added find_available_rooms method

c9cff90

added the ability to reserve an available room for a given date range

e35cbb9

added create_block method

565fe90

added exception raised if the user tries to reserve a room set in a b…

9a34b01

…lock

raises exception if trying to create a block for a room already in an…

d293ecd

…other block

can reserve a specific room from a hotel block

fb7c309

DRY out get_na_objects

aab0f94

refactored, DRY out code

1c5f989

fixed bugs

a5502b6

cleaned out comments

07622ae

added more tests and got 100% coverage

91a26dd

fixed refactored cost method

148daac

added comments abour the requirements

ca5c01f

added set_room_rate method

14deefd

Sopheary Chiv added 11 commits March 18, 2019 23:16

optional enhancement: Read and write CSV files

d1d2660

cleaned up comments

b4648b0

fixed CSV files

db40548

added refactors.txt

cd1b39b

refactored find_available_rooms

1277a05

added a test for self.num_rooms in Room

de1de37

fixed typs

12f4a18

added DateRange class

75795a9

store new room rate in csv files

291b5a9

added CLI

bda6195

fixed typos in refactors.txt

3d0a60d

CheezItMan reviewed Mar 24, 2019

View reviewed changes

Sopheary Chiv added 13 commits March 27, 2019 11:13

added design-activity.md

fd14b95

formatted design-activity.md

24acc5b

answered 2 questions

41a0dd4

finished design-activity

57833d2

reformat design activity

29dc8e4

answered questions in the Revisited Hotel homework

7dbb98b

fixed format in design-activity

ea0ae7e

changed get_na_objects to overlap_blocks_reservations

68f9e10

moved total_cost method to Reservation

fdfb65d

used .find to set room rate

3e75f7e

added more edge cases

d6f2699

cleaned out comments in ReservationManager

dbf9240

delegated some responsibilities to Block, Room and Reservation

c306821

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Sopheary#28

Ports - Sopheary#28
sophearychiv wants to merge 54 commits intoAda-C11:masterfrom
sophearychiv:master

sophearychiv commented Mar 18, 2019 •

edited

Loading

Uh oh!

CheezItMan commented Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

CheezItMan Mar 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sophearychiv commented Mar 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hotel

Comprehension Questions

Uh oh!

CheezItMan commented Mar 24, 2019

Hotel

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sophearychiv commented Mar 18, 2019 •

edited

Loading