Ports- Sav by qqdipps · Pull Request #31 · Ada-C11/hotel

qqdipps · 2019-03-18T07:29:53Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	I used method calls from other methods and classes and chained them together, I wasn't sure how to avoid this so I tried to minimize dependencies by duck typing, one way object composition, and SRP applied to methods and classes the best I could.
What was a design decision you made that changed over time over the project?	Originally I didn't think that room needed its own class. It was a struct in Manifest, but as I progressed I wanted to add behaviors to it so I pulled it out and made it a class on its own.
What was a concept you gained clarity on, or a learning that you'd like to share?	I thought that block should inherit from reservation since it seemed like it was like a reservation but with more behaviors. Then I realized that yes they have lots of things in common, but they have a different purpose and that it would be better to create an abstract class Unavailable in which they could both inherit from.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	A nominal case tests a normal expectation of how an object should behave. Manifest#list_available_rooms_by_date_range: date_range checked, overlaps reservations(inner check-out/ outer of check-in) returns available rooms.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	An edge case tests the outer bounds of possible behaviors of an object. Manifest#list_rooms: returns [] if rooms to list is empty array.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	When I did the pseudocode first I had a better understanding of the helper methods that were required and my code more thoughtful , also testing was easier because I had a more defined idea where I was going.

…e and implemented methods.

…ilable

…or rooms

… check in/out

…helper methods and attribute to determine.

… in block

… not required for user story nor helper method, same can be accomplisted using def list_available_rooms_by_date_range(date_range:).

…ry wants list of reserved rooms only (seems like to not include block) corresponding tests removed as well.

… blocks and added tests

CheezItMan · 2019-03-25T00:42:11Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and good commit messages
Answer comprehension questions	Check, Glad pseudocode helped!
Design
Each class is responsible for a single piece of the program	Check
Classes are loosely coupled	Check
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Check
Wave 3
Create a block of rooms	Check
Check if a block has rooms	Check
Reserve a room from a block	Check
Test coverage	100%
Fundamentals
Names variables, classes and modules appropriately	Check
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Check
Understands the differences between class and instance methods	Check
Appropriately uses iterators and `Enumerable` methods	Check
Appropriately writes and utilizes classes	Check
Appropriately utilizes modules as a namespace	Check
Wrap Up
There is a refactors.txt file	Check
The file provides a roadmap to future changes	Check
Additional Feedback	Well done, you hit the learning goals for this project. Good use of inheritance, although the name is a little hard to understand since it really just contains a date range. Nice work!

CheezItMan · 2019-03-25T00:24:09Z

+      end
+      block.set_number_available(rooms_collection.length)
+      rooms_collection.each do |room|
+        room.unavailable_list << block


This isn't a problem for this project, but if someone wanted to cancel a block, you'd have to find rooms with the block and delete that from each room. Just a little awkward.

CheezItMan · 2019-03-25T00:25:52Z

+      reservation.cost = room.cost_per_night * reservation.duration_in_days * (100 - percent_discount) / 100.0
+    end
+
+    def get_cost_of_booking(reservation:)


This method's a little weird in that you're passing in a reservation and returning the cost of that reservation, which seems that this method is unnecessary.

CheezItMan · 2019-03-25T00:29:46Z

+      setup_rooms(rooms_to_set_up)
+    end
+
+    def setup_rooms(rooms_to_set_up)


these should be private I believe

CheezItMan · 2019-03-25T00:31:15Z

+      rooms << RoomWrapper::room(cost: cost_per_night, room_number: rooms.length + 1)
+    end
+
+    def list_rooms(rooms_to_list: rooms)


Why is this method simply returning the object passed in as an argument?

CheezItMan · 2019-03-25T00:31:56Z

+
+    def find_unavailable_object(id:)
+      rooms.each do |room|
+        room.unavailable_list.each do |unavailable_object|


Unavailable how? A room might be available on a given day and unavailable the next.

CheezItMan · 2019-03-25T00:33:12Z

+    end
+  end
+
+  module RoomWrapper


I'm uncertain this RoomWrapper module serves much purpose.

CheezItMan · 2019-03-25T00:37:37Z

+      expect(valid_block.number_available).must_equal 0
+    end
+
+    it "will check if room available, that is number_available < 0 will return false" do


So you don't raise an error if they try to reserve more rooms from a block than are in the block?

qqdipps added 30 commits March 11, 2019 14:35

created test for reservation class, created reservation class.

4217b34

added test for instance variables and added logic to pass

46ea676

added test for checking if dates are valid

d96daa4

wrote tests then implemented valid_date_range? method.

f835ae8

added exception test and logic for checking date range

ed27068

created test then Manifest class

ba11541

added tests for manifest and created list_rooms method.

14609a0

test for booker class and class added

40efe5c

refactored and changed var names, class names.

20dd6ca

changed file names.

a7ae754

added test and method for booking room.

26c4368

refactored

a460fb2

added test for list_reservations_by_date

8433d45

added tests for listing rooms and listing reserved rooms by given dat…

33784f7

…e and implemented methods.

added layer to structure to calculate price for a given reservation.

bd8ffff

adjusted structure for data and corresponding tests

6ef6b1f

implemented list_reservations_by_date for new DS, all tests passing

f150d0e

moved cost responsibilty to booker, created abstract superclass Unava…

60430a6

…ilable

fixed inheritance, all test's passing

bc9046d

pull room struct out and created class, created factory in manifest f…

bef7e95

…or rooms

adjusted code to additions

34b6aba

added spec file for new class room

3e85d2c

added specific files paths to classes

604716f

removed unrequested feature SALES_TAX_ADJUSTMENT

897287a

refactored and added cost to reservation

365c5b2

removed not implementedError.

375bdfa

removed date parsing. reservation expects date class to be passed for…

51351b8

… check in/out

made tests more robust

5285a01

booker testing upto date.

c8ce193

made tests for room more robust

61b423c

qqdipps added 25 commits March 17, 2019 02:03

fixing mess, block

e4443f8

fixing mess, booker

8c62c93

fixed mess, good place here ->

9ffe8e4

passing tests

9e353e7

completed set_aside_block in booker, all tests passing

b1cfd92

added tests to check if blocks are not avail.

3e5efa0

accomodated tests to block for manifest. all green, and refactoredish

deb4276

added method to check if block as room available for reservation and …

9fbb11d

…helper methods and attribute to determine.

all tests passing

8d6330e

created helper method and tests ok for finding unavailable object by id.

254e543

added booking room associtated with block

f09478c

added helper method to check if room as object.

78e0e8e

inprogress for booking reservation from block

4e1c717

add helper methods for booking room from block

f4c8eee

implemented logic to booking room from block to track rooms remaining…

aaeb862

… in block

finished ?

bf3b5c6

removed method and tests for def list_available_rooms_by_date(date:),…

0267c50

… not required for user story nor helper method, same can be accomplisted using def list_available_rooms_by_date_range(date_range:).

removed list_unavailable_rooms_by_date(date:), not required, user sto…

93190c4

…ry wants list of reserved rooms only (seems like to not include block) corresponding tests removed as well.

tests removed, not saved previously, see last commit

4b92a8e

changed to valid_unavailable_dates? method name

ed2ef55

created refactors txt fixed calculation of discounted reservation via…

adfeee8

… blocks and added tests

added to txt refactors file

388e277

added more to refactors.txt

69fc025

fixed spacing

8c1cfb6

added spacing and test for unavailable id confirmation

de8619c

CheezItMan reviewed Mar 25, 2019

View reviewed changes

qqdipps added 3 commits April 1, 2019 00:37

design activity

340483d

updated hotel, delegated logic to lower level class

e206432

fixed format

c31dbe1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports- Sav#31

Ports- Sav#31
qqdipps wants to merge 85 commits intoAda-C11:masterfrom
qqdipps:master

qqdipps commented Mar 18, 2019

Uh oh!

CheezItMan commented Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

CheezItMan Mar 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

qqdipps commented Mar 18, 2019

Hotel

Comprehension Questions

Uh oh!

CheezItMan commented Mar 25, 2019

Hotel

What We're Looking For

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

CheezItMan Mar 25, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants