Sockets-Bita by Bitaman · Pull Request #40 · Ada-C11/hotel

Bitaman · 2019-03-18T15:08:36Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	deciding about how many classes do I need to keep classes single responsibility and at the same time not having too many classes that their only responsibility is to initialize themselves.
What was a design decision you made that changed over time over the project?	I had thought about creating a booking system for the hotel but then I decided that it wouldn't be necessary and I can use hotel itself to do all the reservations. also I was tempted to make a date range class but I made my rooms keep track of their reservations and that way it was possible to check the date range inside methods.
What was a concept you gained clarity on, or a learning that you'd like to share?	I learned a lot about writing tests. I am not sure how perfect are the test that I wrote for this project but I have a much clearer and better understanding on how to write test now.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	testing to see if the reservation class get initialize correctly is a nominal test.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	I think testing for reservations that on the last day of a reservation or end at the start day of one is an edge case. edge cases are cases that are exactly on the boundary of what is acceptable and what is not.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I started doing that but I caught myself a lot skipping the pseudocode and write the code itself and testing that. but the parts that I tried I really like that it made the whole process of writing code much easier to handle

…ic tests

…king room instead of room_id as an argument for reservation and also have each room keep track of their reservations

…ade my make reservation method take a room from the available room array

…tion array for the room and added more test cases to hotel spec

dHelmgren · 2019-03-29T03:33:56Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	For a project of this size, I would expect more commits.
Answer comprehension questions	Yes
Design
Each class is responsible for a single piece of the program	Yes, but see comments. things are a bit too broken down in this.
Classes are loosely coupled	No, there are a lot of instances of calling instance methods in your Hotel class.
Wave 1
List rooms
Reserve a room for a given date range	yes
List reservations for a given date	Yes
Calculate reservation price	Yes
Invalid date range produces an error	No, you could pass in a backwards set of dates and it wouldn't know.
Test coverage	The tests aren't testing things broadly enough at this point.
Wave 2
View available rooms for a given date range	See comment, this method has a significant bug.
Reserving a room that is not available produces an error	No, due to the error above.
Test coverage	As above.
Wave 3
Create a block of rooms	Yes
Check if a block has rooms	Your block doesn't work to spec, it seems you misunderstood part of the prompt.
Reserve a room from a block	as above.
Test coverage	NA
Fundamentals
Names variables, classes and modules appropriately	Yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	Yes
Appropriately uses methods to break down tasks into smaller simpler tasks	Yes
Understands the differences between class and instance methods	Mostly, but you have a method that seems to have been put in by ritual rather than necessity. See `Hotel#self.load_rooms`.
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	Utilize yes, but you broke down the components too far.
Appropriately utilizes modules as a namespace	no, you didn't use a Module to encapsulate your work.
Wrap Up
There is a refactors.txt file	Not Included
The file provides a roadmap to future changes	NA
Additional Feedback	I can tell you put a lot of work into this submission. You scaffolded out a lot of good elements, but I see that your code has some pretty fundamental errors as well. A lot of this can be salvaged with some better testing, which you admit is something that you're still getting the hang of. I'm going to suggest that you sit down with Dan or Kaida when you get back from break and talk with one of them about how you can catch the things that went wrong here, and how you could improve your testing so that these kinds of mistakes get caught early.

dHelmgren · 2019-03-28T05:26:18Z

+
+  def initialize(id)
+    @id = id
+    @price = 200


This could be a constant somewhere else instead!

dHelmgren · 2019-03-28T05:28:32Z

+    @rooms = []
+    id = 1
+    20.times do
+      room = Room.new(id)


Given your implementation of Room below, what is the difference between a Hash of Int:Array pairs and an array of Room objects?

Besides a guaranteed order, I don't think there is one, because the Room class is basically a stub.

dHelmgren · 2019-03-28T05:30:35Z

+    return all_available
+  end
+
+  def self.load_rooms


Why did you need this method?

dHelmgren · 2019-03-28T05:35:24Z

+    i = 0
+    number_of_dates.times do
+      date = @start_date + i
+      dates.push(date)


Check out the Range class in Ruby: https://ruby-doc.org/core-2.2.0/Range.html

You can replace this method with the following call: (start_date .. end_date)

dHelmgren · 2019-03-28T05:37:06Z

+    # end
+    @room_rate = room_rate
+    @cost = ((@dates.length) - 1) * (@room_rate.to_i)
+    @dates = date_range


why do you make this call again? super has already called it!

dHelmgren · 2019-03-28T05:44:47Z

+    @reservations.each do |reservation|
+      reserved << reservation.room
+    end
+    return @rooms - reserved.uniq


Nice work on this! very clear and readable.

dHelmgren · 2019-03-28T05:46:26Z

+    it "makes an array of all the dates in the blocks date range" do
+      expect(@block.dates).must_be_kind_of Array
+      expect(@block.dates.length).must_equal 5
+    end


Some tests you should be doing:

Can you make a reservation into the block?

What if someone tries to book a room in the block and they aren't from the block?

What if someone tries to book a room in the block that extends past the block dates?

dHelmgren · 2019-03-28T05:47:32Z

+      i += 1
+    end
+    return dates
+  end


Your implementation of block seems to miss one of the points of a block; that is, one needs to be able to book a room that is in the block, on top of creating the block itself.

dHelmgren · 2019-03-29T03:07:21Z

+    available_rooms = []
+    all_available = []
+    @reservations.each do |reservation|
+      if start_date >= reservation.dates.last || end_date <= reservation.dates.first


This will return true for a room on a single reservation, but that same room could be booked by another reservation. The list of available rooms needs to be built subtractively, not additively.

Example:
load_availables(Jan 3rd 2019, Jan 15th 2019)

if someone has booked room 1 for those exact dates, but there was another booking that happened from Jan 1st to Jan 3rd in room 1, room 1 would be added to the list of available rooms.

dHelmgren · 2019-03-29T03:10:19Z

+      @reservation2 = @hotel.make_reservation(start_date2, end_date2)
+      start_date3 = Date.new(2018, 3, 5)
+      end_date3 = start_date3 + 3
+      @reservation3 = @hotel.make_reservation(start_date3, end_date3)


There is a significant flaw in this test: you used the same date range for all 3 bookings. This won't catch the case mentioned in the Hotel#load_availables comment above, where the same room is booked back to back.

…he load available method

Bitaman added 11 commits March 11, 2019 12:28

tested the gaurd and it's working

8d4078e

fixed the first test to make sure guard is working

6839b01

made a hotel class, a room class and a reservation class and with bas…

a27ed16

…ic tests

fixed my Dates in the tests

4f961d3

added make_reservation method to make reservation for given dates

c13f3bb

made my existing tests DRY

83a6305

made changes to the reservation class and make reservation method, ta…

0b1d9a2

…king room instead of room_id as an argument for reservation and also have each room keep track of their reservations

wrote a method to load all the available rooms for a date range and m…

2476825

…ade my make reservation method take a room from the available room array

changed make reservation method to add the reservation to the reserva…

3464292

…tion array for the room and added more test cases to hotel spec

makes the Block class and tests

085ec3f

wrote the make block method and tests

3e90c45

dHelmgren reviewed Mar 29, 2019

View reviewed changes

added the design activity file and fixed the code. still working on t…

c0c5301

…he load available method

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sockets-Bita#40

Sockets-Bita#40
Bitaman wants to merge 12 commits intoAda-C11:masterfrom
Bitaman:master

Bitaman commented Mar 18, 2019

Uh oh!

dHelmgren commented Mar 29, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 28, 2019

Uh oh!

dHelmgren Mar 29, 2019

Uh oh!

dHelmgren Mar 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Bitaman commented Mar 18, 2019

Hotel

Comprehension Questions

Uh oh!

dHelmgren commented Mar 29, 2019

Hotel

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants