Ports - Jillianne Ramirez

[jillirami]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Determining the relationship between the hotel manager, the rooms and the reservations and what they knew about each other.
What was a design decision you made that changed over time over the project?	I initially did not have a date range class, and as I created multiple ArgumentErrors regarding date, I created this class to dry my code.
What was a concept you gained clarity on, or a learning that you'd like to share?	I gained clarity on dependence of classes and how change in one class can affect another.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	it "makes a reservation", testing that the code works normally.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	it "raises an exception if a block is the wrong size" , testing the border of possible inputs
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I feel that I jumped around in the process a lot, especially in the beginning. I would focus on pseudocode more at first next time rather than almost attempting BUFD.

[kaidamasaki]

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Yes.
Answer comprehension questions	Yes.
Design
Each class is responsible for a single piece of the program	Mostly. HotelManager has a little more functionality than I'd like.
Classes are loosely coupled	Yes.
Wave 1
List rooms	Yes.
Reserve a room for a given date range	Yes.
List reservations for a given date	Yes.
Calculate reservation price	Yes.
Invalid date range produces an error	Yes.
Test coverage	Yes.
Wave 2
View available rooms for a given date range	Yes.
Reserving a room that is not available produces an error	Yes. (Rooms are selected automatically, an error is raised if no rooms are free.)
Test coverage	Yes.
Wave 3
Create a block of rooms	Yes.
Check if a block has rooms	Yes.
Reserve a room from a block	No.
Test coverage	Yes.
Fundamentals
Names variables, classes and modules appropriately	Yes.
Understanding of variable scope - local vs instance	Yes.
Can create complex logical structures utilizing variables	Yes.
Appropriately uses methods to break down tasks into smaller simpler tasks	Yes.
Understands the differences between class and instance methods	Yes.
Appropriately uses iterators and Enumerable methods	Yes.
Appropriately writes and utilizes classes	Yes.
Appropriately utilizes modules as a namespace	Yes.
Wrap Up
There is a refactors.txt file	Yes.
The file provides a roadmap to future changes	Yes.
Additional Feedback	Great job! There were a few small things but over all this is a really solid solution!

[kaidamasaki]

I would have liked to see Block use a DateRange object internally instead of just having a start and end date.

[kaidamasaki]

I'd like to see this turned into a constructor that raises since a date range is a thing you can perform meaningful operations on.

[kaidamasaki]

Ruby will be looking for names locally first, prioritizing local names, since they're all in the same module, there's no need to namespace Hotel::Room. Room should just work! Same with the rest of the namespacing in the code.

[kaidamasaki]

You can use unless to make this a little clearer.

Suggested change

	if !HotelManagementSystem::DateRange.is_valid?(start_date, end_date)
	unless HotelManagementSystem::DateRange.is_valid?(start_date, end_date)

[kaidamasaki]

Very slightly cleaner.

Suggested change

	raise ArgumentError, "There is no room available for these dates." if room_assignment == nil
	raise ArgumentError, "There is no room available for these dates." unless room_assignment

[kaidamasaki]

I think all this line does is give you back nil if block isn't in @blocks.