Karla G - Sockets by kguadron · Pull Request #42 · Ada-C11/hotel

kguadron · 2019-03-18T15:58:52Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	An initial design challenge I faced was deciding which actions (methods) belong to which classes. I encountered these same questions in wave three when creating the hotel block.
What was a design decision you made that changed over time over the project?	When I planned out wave three, I intended to have a BlockReservation class that inherited from the Reservation class. I changed my mind as I built the Block class.
What was a concept you gained clarity on, or a learning that you'd like to share?	The whole process of designing and building a system is much clearer to me. At the beginning of the project, I felt lost with that and by Wave 3 I was able to make decisions with more intentionality.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	An example of a nominal test I wrote was testing to see if objects were an instance of the intended class.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	An edge case I tested for my reserve_block_room was checking if the block id existed or not.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I further developed that skill during this project. Following the trend I explained before, during the beginning phases it felt more tenuous and by Wave 3 I pseudocoded everything and felt it really helped with executing the writing of the code.

…elper

…spec_helper. Created initialize method for Room class

…ious commmit

… tests

…ethods to be created.

…ly be used to determine which room a guest will be assigned to when a resewrvation is made

…ossible reservation date combinations

…l as accompamying specs. Created block class and tests

… Hotel with tests

droberts-sea · 2019-03-27T23:33:51Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	yes
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Wave 1
List rooms	yes
Reserve a room fr a given date range	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	yes
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	yes
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes
Test coverage	yes
Fundamentals
Names variables, classes and modules appropriately	mostly
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	mostly
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes
Additional Feedback	Excellent job overall. This code is well-organized, well-written, and well-tested. I've left a number of inline comments, but in general I like what I see. Keep up the hard work!

droberts-sea · 2019-03-27T23:15:43Z

+    def see_reservations_by_date(date)
+      this_dates_reservations = []
+      @all_reservations.each do |reservation|
+        this_dates_reservations << reservation if reservation.start_date == date


The .select enumerable might be helpful to clean up this code.

droberts-sea · 2019-03-27T23:16:54Z

+    def see_available_rooms_by_date(possible_start_date, possible_end_date)
+      these_dates_available_rooms = []
+      @all_rooms.each do |room|
+        these_dates_available_rooms << room if room.date_available?(possible_start_date, possible_end_date)


On line 34, I like that you call room.date_available? instead of having a bunch of date math here in Hotel. This is what Metz is talking about when she says you should "ask for what instead of telling how".

droberts-sea · 2019-03-27T23:18:09Z

+    def room_available?(new_start_date, new_end_date)
+      @all_rooms.each do |room|
+        return room if room.date_available?(new_start_date, new_end_date)
+      end


In Ruby, ending a method name with a question mark implies that it returns either true or false, but this method may return an instance of Room. A better name might be find_available_room.

droberts-sea · 2019-03-27T23:19:54Z

+    def hold_block(start_date, end_date, room_collection)
+      room_collection.each do |room|
+        raise ArgumentError, "Room #{room.number} is already in a block" if room.block_id != nil
+      end


I don't know that I agree with the idea of storing the block_id as an instance variable on the Room. That means that each room can only ever be included in one block. However, blocks don't last for ever - they're for a set amount of time, and on other dates the room should be free to be included in other blocks.

droberts-sea · 2019-03-27T23:21:33Z

+      if desired_block == nil
+        raise ArgumentError, "The block entered does not exist or it does not have any rooms available for reseervation"
+      elsif desired_block.room_still_available?
+        reservation = HotelSystem::Reservation.new(room: room, start_date: start_date, end_date: end_date, guest: guest)


This will not raise an exception if the block is full. To do so, you would need code like this:

if desired_block == nil || desired_block.room_still_available? raise ArgumentError #... else # ...

However, I would prefer you split the two cases and provide a little more detailed information in your error message.

droberts-sea · 2019-03-27T23:21:55Z

+
+    def calculate_cost
+      return ("%.2f" % ((@end_date - @start_date) * @price)).to_f
+    end


I like the decision to make this a method rather than storing the cost as an instance variable. That way if the number of nights or the cost per night were to change (say in a future version of the program), the total cost will automatically be correct.

droberts-sea · 2019-03-27T23:24:23Z

+        if possible_start_date == reservation.start_date
+          return false
+        elsif reservation.start_date < possible_start_date && possible_start_date < reservation.end_date
+          return false


You can simplify all of this complex conditional logic into one line! See the instructor implementation.

Each of these would make an excellent test case though.

droberts-sea · 2019-03-27T23:30:45Z

+      hotel.reserve_room(
+        room,
+        Date.new(2019, 3, 10),
+        Date.new(2019, 3, 13),


You do a lot of repeated setup work throughout these tests. Would it be possible to consolidate this into a shared before block or something similar?

droberts-sea · 2019-03-27T23:32:08Z

+  describe "room_available? method" do
+    before do
+      @hotel = HotelSystem::Hotel.new
+      @hotel.all_rooms.slice!(2..19)


This is a clever way to make this test work. Another option would be to pass in the number of rooms to the Hotel constructor, possibly with a default value of 20.

droberts-sea · 2019-03-27T23:33:09Z

+    it "returns false if the possible start date matches the start date of the reservation" do
+      expect(@room.date_available?(Date.new(2019, 3, 11), Date.new(2019, 3, 12))).must_equal false
+      expect(@room.date_available?(Date.new(2019, 3, 11), Date.new(2019, 3, 14))).must_equal false
+      expect(@room.date_available?(Date.new(2019, 3, 11), Date.new(2019, 3, 15))).must_equal false


Good work nailing all of these test cases.

kguadron added 22 commits March 11, 2019 10:57

Added Room class and test to check Room instantiation. Updated spec_h…

06c4470

…elper

Made lib and spec files for the Reservation and Hotel class. Updated …

f4ad29a

…spec_helper. Created initialize method for Room class

Commiting spec files which hadn't been staged at the time of the prev…

55a39bd

…ious commmit

Added initalize methods to all classes and some method signatures

383479b

Added calculate_cost method for reservation. Refined reservation_spec…

c2f5171

… tests

Refactored to have all tests passing. Cretaed method signatures for m…

a9b031a

…ethods to be created.

Created date_overlap? method for Room and accompanying tests

bc7aedf

Added the room_available? method and teststo hotel that will eventual…

43d7b0d

…ly be used to determine which room a guest will be assigned to when a resewrvation is made

Refined testing for Hotel's room_available? method

ec71da6

Updated Room's date_available? method and tests to account for more p…

46c6ee3

…ossible reservation date combinations

Added reserve_room method to Hotel with accompanying tests

eef812d

Added the see_reservations_by_date method and tests

1fece84

Created new files for block and block room reservation classes as wel…

9c60b7f

…l as accompamying specs. Created block class and tests

Updated block class with room_collection_blockable? method

f856a0f

Updated Room class with status and block_id attributes

50b673e

Deleted status as Room instance attribute. Added hold_block method to…

4106ba5

… Hotel with tests

Added reserve_block_room method and tests. Edited formatting

d484bd3

Created refactors.txt

8290b73

Added another point to refactors.txt

2b99a49

Added another point to refactors.txt

0a1273d

Deleted block room reservation lib and spec files

67d51d3

Added more to refactors.txt

4615c9a

droberts-sea reviewed Mar 27, 2019

View reviewed changes

Added Evaluating Responsibility Activity

ff77f29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Karla G - Sockets#42

Karla G - Sockets#42
kguadron wants to merge 23 commits intoAda-C11:masterfrom
kguadron:master

kguadron commented Mar 18, 2019

Uh oh!

droberts-sea commented Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

droberts-sea Mar 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kguadron commented Mar 18, 2019

Hotel

Comprehension Questions

Uh oh!

droberts-sea commented Mar 27, 2019

Hotel

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants