Conversation
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
There are a lot of good things here, but some unfinished work as well and some bugs. Take a look at my comments and let me know if you have any questions.
Remember I have office hours and can meet by appointment.
| class LinkedList | ||
| def initialize | ||
| @head = nil # keep the head private. Not accessible outside this class | ||
| @tail = nil |
| # end | ||
| # @tail = current | ||
|
|
||
| print @head.data |
There was a problem hiding this comment.
This doesn't need to be in the submission.
| # Space Complexity | ||
| def add_last(value) | ||
| new_node = Node.new(value) | ||
| @tail = new_node |
There was a problem hiding this comment.
You should do @tail.next = new_node before this. Then except for checking if the list was empty before, you would be finished. No loop required.
| current = @head | ||
|
|
||
| if current | ||
| index.times do |
There was a problem hiding this comment.
What if index is larger than the size of the list?
| raise NotImplementedError | ||
| if @head | ||
| current = @head | ||
| max = 0 |
There was a problem hiding this comment.
What if the list is filled with negative numbers? What if it's not a list of integers?
| # Space Complexity | ||
| def length | ||
| raise NotImplementedError | ||
| # CHRIS - this isn't working! I'm pretty sure this is because it's not updating tail, bu |
There was a problem hiding this comment.
This is because your add_last method isn't updating @tail properly.
| def get_at_index(index) | ||
| raise NotImplementedError | ||
| def search(value) | ||
| current = @head |
| current = @head | ||
| index = count - 1 | ||
|
|
||
| count.times do |
There was a problem hiding this comment.
This works, but it's an O(n2) algorithm. Is there a better way?
2 participants
No description provided.