Open
Conversation
CheezItMan
reviewed
Sep 3, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, some of it is unfinished, but you hit the major learning goals here. You also did well identify the Big-O of each method. Nice work!
| def add_first(value) | ||
| raise NotImplementedError | ||
| node = Node.new(value) | ||
| if @head != nil |
| def search(value) | ||
| raise NotImplementedError | ||
| current = @head | ||
| return false if !current.next |
There was a problem hiding this comment.
What about if value was at the head?
| current = @head | ||
| return false if !current.next | ||
|
|
||
| while current.next != nil |
There was a problem hiding this comment.
What if the value is in the last node, where it's next is nil?
| raise NotImplementedError | ||
| return if @head.nil? | ||
| current = @head | ||
| max = nil |
There was a problem hiding this comment.
It would be better if you set max = @head.data
| while current != nil | ||
| if current.data > max | ||
| max = current.data | ||
| else |
|
|
||
| while current != nil | ||
| if current.data == value | ||
| if @head.data == value |
There was a problem hiding this comment.
Does this @head.data == value need to be in the loop?
| # Space Complexity: O(1) | ||
| def delete(value) | ||
| raise NotImplementedError | ||
| return if !@head |
There was a problem hiding this comment.
There's a test failing for this, but that's because the test uses add_last
| # Space Complexity | ||
| # Time Complexity: linear | ||
| # Space Complexity: O(1) | ||
| def reverse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.