Open
Conversation
Merge branch 'master' of https://github.com/SabrinaLauredan/adagrams-py
spitsfire
reviewed
Oct 9, 2021
Collaborator
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Great job, Sabrina and Shay! Your code was easy to read! I made a few suggestions to dry up your code, but all in all this was nicely done!!
Keep it up!
Comment on lines
+11
to
+23
| LETTERS_POOL = [] | ||
| for letter in LETTERS_DICT: | ||
| letters_string = letter * LETTERS_DICT[letter] | ||
| for letter in letters_string: | ||
| LETTERS_POOL.append(letter) | ||
| ''' | ||
| LETTERS_POOL = ['A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'B', 'B', 'C', \ | ||
| 'C', 'D', 'D', 'D', 'D', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', \ | ||
| 'E', 'E', 'F', 'F', 'G', 'G', 'G', 'H', 'H', 'I', 'I', 'I', 'I', 'I', 'I', \ | ||
| 'I','I', 'I', 'J', 'K', 'L', 'L', 'L', 'L', 'M', 'M', 'N', 'N', 'N', 'N', 'N', \ | ||
| 'N', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'P', 'P', 'Q', 'R', 'R', 'R', 'R', \ | ||
| 'R', 'R', 'S', 'S', 'S', 'S', 'T', 'T', 'T', 'T', 'T', 'T', 'U', 'U', 'U', 'U', \ | ||
| 'V', 'V', 'W', 'W', 'X', 'Y', 'Y', 'Z'] |
Collaborator
There was a problem hiding this comment.
this works! Though I think since you put in the effort of coding the algorithm out, you should show it off! Maybe we can do something like this:
Suggested change
| LETTERS_POOL = [] | |
| for letter in LETTERS_DICT: | |
| letters_string = letter * LETTERS_DICT[letter] | |
| for letter in letters_string: | |
| LETTERS_POOL.append(letter) | |
| ''' | |
| LETTERS_POOL = ['A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'A', 'B', 'B', 'C', \ | |
| 'C', 'D', 'D', 'D', 'D', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', 'E', \ | |
| 'E', 'E', 'F', 'F', 'G', 'G', 'G', 'H', 'H', 'I', 'I', 'I', 'I', 'I', 'I', \ | |
| 'I','I', 'I', 'J', 'K', 'L', 'L', 'L', 'L', 'M', 'M', 'N', 'N', 'N', 'N', 'N', \ | |
| 'N', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'O', 'P', 'P', 'Q', 'R', 'R', 'R', 'R', \ | |
| 'R', 'R', 'S', 'S', 'S', 'S', 'T', 'T', 'T', 'T', 'T', 'T', 'U', 'U', 'U', 'U', \ | |
| 'V', 'V', 'W', 'W', 'X', 'Y', 'Y', 'Z'] | |
| def get_letters_pool: | |
| for letter in LETTERS_DICT: | |
| letters_pool = [] | |
| letters_string = letter * LETTERS_DICT[letter] | |
| for letter in letters_string: | |
| letters_pool.append(letter) | |
| return letters_pool | |
| LETTERS_POOL = get_letters_pool() |
Collaborator
There was a problem hiding this comment.
this way, if the letter scores or availability change, then you only need to change the original dictionary!
| "R": 1, "U": 1, "T": 1, "W": 4, "V": 4, "Y": 4, | ||
| "X": 8, "Z": 10} | ||
|
|
||
| def draw_letters(): |
Collaborator
There was a problem hiding this comment.
👍 short and sweet! love it!
| a letter more times than it appears in the letter_bank | ||
| Returns True or False | ||
| ''' | ||
| temp_letter_bank = letter_bank.copy() |
Collaborator
There was a problem hiding this comment.
👍 good job reducing side effects!
Comment on lines
+57
to
+61
| total = 0 | ||
| if len(word) >= 7: | ||
| total += 8 | ||
| total += sum(SCORES[letter] for letter in word.upper()) | ||
| return total |
Collaborator
There was a problem hiding this comment.
ohh interesting doing the +8 points first, then using sum() for the for loop!
| return False | ||
| return True | ||
|
|
||
| def score_word(word): |
Comment on lines
+75
to
+77
| if score_word(word) > highest_score: | ||
| winning_word = word | ||
| highest_score = score_word(word) |
Collaborator
There was a problem hiding this comment.
maybe we can dry this up a bit, so we only use score_word once!
Suggested change
| if score_word(word) > highest_score: | |
| winning_word = word | |
| highest_score = score_word(word) | |
| current_score = score_word(word) | |
| if current_score > highest_score: | |
| winning_word = word | |
| highest_score = current_score |
Comment on lines
+78
to
+81
| elif score_word(word) == highest_score: | ||
| if len(word) == 10 and len(word) != len(winning_word): | ||
| winning_word = word | ||
| highest_score = score_word(word) |
Collaborator
There was a problem hiding this comment.
now that we have the current_score variable, we can do the same to this conditional statement as above!
| highest_score = score_word(word) | ||
| elif len(word) < len(winning_word) and len(winning_word) != 10: | ||
| winning_word = word | ||
| highest_score = score_word(word) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.