Open
Conversation
spitsfire
reviewed
Oct 9, 2021
Collaborator
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Tiffany and Rhyannon, heck yeah! This looks great! Easy to read, loved all the helper functions you constructed in order to make get_highest_word_score much simpler to read.
Nicely done!
Comment on lines
+26
to
+34
| i = 0 | ||
| while len(letters) < 10: | ||
| random_letter = random.choice(list(LETTER_POOL)) | ||
| if letter_count[random_letter] > 0: | ||
| letter_count[random_letter] -= 1 | ||
| letters.append(random_letter) | ||
| if letter_count[random_letter] < 0: | ||
| letters.remove(random_letter) | ||
| i += 1 |
Collaborator
There was a problem hiding this comment.
we don't actually need i in this loop! the while loop is checking the length of the letters list, which is not dependant on i.
let's get rid of line 26 and line 34!
| returns an array of random 10 strings from LETTER_POOL | ||
| """ | ||
| letters = [] | ||
| letter_count = LETTER_POOL.copy() # could also be letter_bank, but not sure yet |
Collaborator
There was a problem hiding this comment.
👍 good job reducing side effects
| otherwise returns False. | ||
| """ | ||
| #this method copies the letter bank list | ||
| letter_bank_duplicate = letter_bank[:] |
Collaborator
There was a problem hiding this comment.
👍 keeps side effects away
| return letters | ||
|
|
||
| # Wave 2 | ||
| def uses_available_letters(word, letter_bank): |
| returns extra points if word is seven letters or more | ||
| """ | ||
| total_score = 0 | ||
| word_case_check = word.upper() |
|
|
||
|
|
||
| # Wave 4 | ||
| def get_score_dict(word_list): |
Collaborator
There was a problem hiding this comment.
👍 love a good helper function!
Comment on lines
+94
to
+97
| score_dictionary = get_score_dict(word_list) | ||
| top_word = max(score_dictionary, key=score_dictionary.get) | ||
| all_scores = get_score_dict(word_list).values() | ||
| top_word_score = max(all_scores) |
Collaborator
There was a problem hiding this comment.
look at all these helper functions helping!!!
| elif len(word) == 10: | ||
| top_word = word | ||
|
|
||
| return top_word, top_word_score No newline at end of file |
| 'N': 6, 'O': 8, 'P': 2, 'Q': 1, 'R': 6, 'S': 4, 'T': 6, | ||
| 'U': 4, 'V': 2, 'W': 2, 'X': 1, 'Y': 2, 'Z': 1} | ||
|
|
||
| SCORE_CHART = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.