Maple - Tiana Wofford and Rachael McBride #47
Open
rachael-mcbride wants to merge 6 commits intoAda-C16:masterfrom
Open
Maple - Tiana Wofford and Rachael McBride #47rachael-mcbride wants to merge 6 commits intoAda-C16:masterfrom
rachael-mcbride wants to merge 6 commits intoAda-C16:masterfrom
Conversation
tgoslee
reviewed
Oct 5, 2021
Comment on lines
+33
to
+36
| letter_pool = [] | ||
| for letter, frequency in LETTER_KEY.items(): | ||
| for number in range(frequency): | ||
| letter_pool.append(letter) |
There was a problem hiding this comment.
I would suggest looking into copy() and deepcopy() to create a copy of your letter pool https://docs.python.org/3/library/copy.html
tgoslee
reviewed
Oct 5, 2021
|
|
||
| return user_hand | ||
|
|
||
| def uses_available_letters(word, letter_bank): |
tgoslee
reviewed
Oct 5, 2021
Comment on lines
+55
to
+69
| for letter in word: | ||
| if letter in ['A', 'E', 'I', 'O', 'U', 'L', 'N', 'R', 'S', 'T']: | ||
| score += 1 | ||
| elif letter in ['D', 'G']: | ||
| score += 2 | ||
| elif letter in ['B', 'C', 'M', 'P']: | ||
| score += 3 | ||
| elif letter in ['F', 'H', 'V', 'W', 'Y']: | ||
| score += 4 | ||
| elif letter in ['K']: | ||
| score += 5 | ||
| elif letter in ['J', 'X']: | ||
| score += 8 | ||
| elif letter in ['Q', 'Z']: | ||
| score += 10 |
There was a problem hiding this comment.
You could create a dictionary with these as key-value pairs. Or you could create a constant global value that holds this data and then do something like:
Suggested change
| for letter in word: | |
| if letter in ['A', 'E', 'I', 'O', 'U', 'L', 'N', 'R', 'S', 'T']: | |
| score += 1 | |
| elif letter in ['D', 'G']: | |
| score += 2 | |
| elif letter in ['B', 'C', 'M', 'P']: | |
| score += 3 | |
| elif letter in ['F', 'H', 'V', 'W', 'Y']: | |
| score += 4 | |
| elif letter in ['K']: | |
| score += 5 | |
| elif letter in ['J', 'X']: | |
| score += 8 | |
| elif letter in ['Q', 'Z']: | |
| score += 10 | |
| for letter in word: | |
| score += LETTER_VALUES[letter.upper()] |
tgoslee
reviewed
Oct 5, 2021
|
|
||
| return score | ||
|
|
||
| def get_highest_word_score(word_list): |
|
Great work! I added some comments on refactoring and using constant global variables! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.