Conversation
spitsfire
left a comment
spitsfire
left a comment
There was a problem hiding this comment.
Andrea and Jesse, nicely done! Your code is easily readable! My main suggestion is shortening your conditionals in get_highest_word_score and remove those that have no actionable commands nested inside
|
|
||
| def draw_letters(): | ||
| pass | ||
| letters_left = LETTER_POOL.copy() |
There was a problem hiding this comment.
👍 glad to see a copy() so you don't produce side effects
| pass | ||
| letters_left = LETTER_POOL.copy() | ||
| choice_ten = [] | ||
| while len(choice_ten) < 10: |
There was a problem hiding this comment.
I like the while loop! It's six to half a dozen of the other using a for-loop instead, but I think this makes more sense readability-wise
| letter = random.choice(list(letters_left)) | ||
| if letters_left[letter] > 0: | ||
| choice_ten.append(letter) | ||
| letters_left[letter] -= 1 | ||
| return choice_ten |
There was a problem hiding this comment.
👍 glad you spotted that you need to check if there are still letters available after randomly selecting a key from random.choice() since it could still be picked, but have 0 availability.
|
|
||
| def uses_available_letters(word, letter_bank): | ||
| pass | ||
| def uses_available_letters(word, choice_ten): |
| return False | ||
| return True | ||
|
|
||
| def score_word(word): |
| if score < top_score: | ||
| pass | ||
| elif score > top_score: | ||
| top_word = word | ||
| top_score = score | ||
| elif score == top_score: | ||
| if len(word) == len(top_word): | ||
| pass | ||
| elif len(top_word) == 10: | ||
| pass | ||
| elif len(word) == 10: | ||
| top_word = word | ||
| top_score = score | ||
| elif len(word) < len(top_word): | ||
| top_word = word | ||
| top_score = score | ||
| return top_word, top_score |
There was a problem hiding this comment.
while this works great, you can also consider removing any if statements that don't have any actionable commands inside of it, like line 102 and 104.
If it's because it's easier to read, awesome! totally valid! you are likely to see these if statements stripped out, though to keep the code drier.
|
|
||
|
|
||
|
|
||
|
|
| @@ -1,11 +1,117 @@ | |||
| import random | |||
|
|
|||
| LETTER_POOL = { | |||
There was a problem hiding this comment.
:+1 good job making this a constant variable with all caps
|
|
||
|
|
3 participants
No description provided.