Spruce - Mary Tian by Mary-Tian · Pull Request #52 · Ada-C16/adagrams-py

Mary-Tian · 2021-09-27T05:45:12Z

No description provided.

To update the repository

… still refactor.

…ble names for clarity in score_word function

… function as well

audreyandoy

Great work Mary and Rebecca!

Your submission covers all the learning goals and passes all the tests! Overall, the code was clean and easy to read. This project is definitely worthy of a green grade 🟢 🌲✨

My feedback primarily focuses on ways to use guard clauses, using const variables, and syntax for iterating through dictionaries. I also loved all the docstrings under each function, they were definitely helpful in understanding your thought process for these solutions.

Keep up the great work 🌲 ✨

audreyandoy · 2021-10-10T05:47:26Z

+    LETTER_POOL = {
+        'A': 9, 'B': 2, 'C': 2, 'D': 4, 'E': 12, 'F': 2, 'G': 3, 'H': 2, 'I': 9, 'J': 1,
+        'K': 1, 'L': 4, 'M': 2, 'N': 6, 'O': 8, 'P': 2, 'Q': 1, 'R': 6, 'S': 4, 'T': 6, 'U': 4,
+        'V': 2, 'W': 2, 'X': 1, 'Y': 2, 'Z': 1
+    }


Long chunks of data like letter_bank tend to clutter functions and require more scrolling to see the rest of the function body. Consider moving this dictionary outside of this function (or in a new file) as a constant variable to be referenced in draw_letters.

audreyandoy · 2021-10-11T19:53:55Z

+        'K': 1, 'L': 4, 'M': 2, 'N': 6, 'O': 8, 'P': 2, 'Q': 1, 'R': 6, 'S': 4, 'T': 6, 'U': 4,
+        'V': 2, 'W': 2, 'X': 1, 'Y': 2, 'Z': 1
+    }
+    letter_to_draw = list(LETTER_POOL.keys())


Suggested change

letter_to_draw = list(LETTER_POOL.keys())

letter_to_draw = list(LETTER_POOL)

We can omit keys() as the default iterator for dictionaries are its own keys. This means the list function will iterate through LETTER_POOL and create a list of its keys.

audreyandoy · 2021-10-11T19:55:13Z

+    for letter in random.sample(letter_to_draw, 10):
+        if letter not in letters_drawn:
+            letters_drawn.append(letter)
+            letter_count[letter] = 1
+        elif letter_count[letter] < LETTER_POOL[letter]:
+            letters_drawn.append(letter)
+            letter_count[letter] += 1


Love the use of a frequency map to keep track of the letters being drawn!

We could also use sample to build letters_drawn directly from LETTER_POOL.

letters_drawn = random.sample(LETTER_POOL.keys(), counts=LETTER_POOL.values(), k=10)

Here's the sample documentation, if you'd like to learn more about the method.

audreyandoy · 2021-10-11T20:05:10Z

+    for letter in word:
+        if letter not in letter_bank or word.count(letter) > letter_bank.count(letter):
+            is_valid = False
+        else:
+            is_valid = True
+
+    return is_valid


Great use of a guard clause here. We can make the code even neater by getting rid of the else clause (aka the dangly bit). To do so, we can take advantage of using the is_valid flag to describe the single scenario where is_valid would be false in the guard clause. Otherwise, the function will just return True. Like so:

is_valid = True for letter in word: if letter not in letter_bank or word.count(letter) > letter_bank.count(letter): is_valid = False return is_valid

Suggested change

for letter in word:

if letter not in letter_bank or word.count(letter) > letter_bank.count(letter):

is_valid = False

else:

is_valid = True

return is_valid

is_valid = True

for letter in word:

if letter not in letter_bank or word.count(letter) > letter_bank.count(letter):

is_valid = False

return is_valid

audreyandoy · 2021-10-11T20:05:52Z

+    LETTER_POINTS = {
+        'A': 1, 'B': 3, 'C': 3, 'D': 2, 'E': 1, 'F': 4, 'G': 2, 'H': 4, 'I': 1, 'J': 8,
+        'K': 5, 'L': 1, 'M': 3, 'N': 1, 'O': 1, 'P': 3, 'Q': 10, 'R': 1, 'S': 1, 'T': 1, 'U': 1,
+        'V': 4, 'W': 4, 'X': 8, 'Y': 4, 'Z': 10
+    }


Similar to my feedback on LETTER_POOL, we can declutter this function by moving LETTER_POINTS outside of the function as a const variable.

audreyandoy · 2021-10-11T20:06:40Z

+        'V': 4, 'W': 4, 'X': 8, 'Y': 4, 'Z': 10
+    }
+    bonus_range = [7, 8, 9, 10]
+    total = sum([LETTER_POINTS[letter] for letter in word.upper()])


LOVELY use of list comprehension here!

audreyandoy · 2021-10-11T20:06:58Z

+    if len(word) in bonus_range:
+        total += 8
+
+    return total


This function is so neat, great work!

audreyandoy · 2021-10-11T20:21:16Z

+    smallest_word_len = min((len(key) for key in words_scored_dict.keys()))
+    largest_word_len = max((len(key) for key in words_scored_dict.keys()))


keys() can be removed as the default iterator for dicts are its own keys.

Suggested change

smallest_word_len = min((len(key) for key in words_scored_dict.keys()))

largest_word_len = max((len(key) for key in words_scored_dict.keys()))

smallest_word_len = min((len(key) for key in words_scored_dict.keys()))

largest_word_len = max((len(key) for key in words_scored_dict.keys()))

Really cool use of dictionary and list comprehensions!!

audreyandoy · 2021-10-11T20:25:37Z

+            if len(user_word) != 10:
+                continue
+            elif len(user_word) == 10:
+                winning_word = user_word
+                highest_word_score = score
+                break


We can take out if len(user_word) != 10 as the loop will continue anyway.

Suggested change

if len(user_word) != 10:

continue

elif len(user_word) == 10:

winning_word = user_word

highest_word_score = score

break

if len(user_word) == 10:

winning_word = user_word

highest_word_score = score

break

audreyandoy · 2021-10-11T20:25:45Z

+        elif score == highest_word_score:
+            winning_word = user_word
+
+    return winning_word, highest_word_score


Great work!

rzuick and others added 19 commits September 22, 2021 15:27

completed draw_letters() function

fa003b2

Merge branch 'master' of https://github.com/Mary-Tian/adagrams-py

58cde09

To update the repository

updated draw_letters() to use the LETTER_POOL dict included in tests

58e4683

updated uses_available_letters() and passed all tests in wave 02. can…

ede8403

… still refactor.

crefactored uses_available_letters() to be more concise

d22f5b3

thoughts for tackling score_word(word)

41eac74

condensed LETTER_POOL dict and deleted import string

578b283

Changed variable names in draw_letters for clarity.

8f264ab

Completed Wave 3, all tests passing.

9489155

formatted file to align with pep8 standards

9569f75

refactored uses_available_letters function for clarity. updated varia…

8e30f04

…ble names for clarity in score_word function

created docstrings for uses_available_letters function

692d319

Created dictionary for get_highest_word_score. Working on rest of code.

7f1428d

finished get_highest_word_score function. game.py passing all waves.

b091b4a

completing merge

c1f82c3

removed commented code

19f5d56

refactored score_word function with list comprehension

1f82866

added docstrings for get_highest_word_score function. refactored this…

8b1289b

… function as well

updated comment about rando module imported

d8e63cf

audreyandoy reviewed Oct 11, 2021

View reviewed changes

	letter_to_draw = list(LETTER_POOL.keys())
	letter_to_draw = list(LETTER_POOL)

		smallest_word_len = min((len(key) for key in words_scored_dict.keys()))
		largest_word_len = max((len(key) for key in words_scored_dict.keys()))

Conversation

Mary-Tian commented Sep 27, 2021

Uh oh!

audreyandoy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants