Open
Conversation
kyra-patton
reviewed
May 5, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
🤠 Nice work Afina. I left some comments on time and space complexity, but otherwise looks good. Answers to the comprehension questions are also solid.
🟢
| // Each subarray will have strings which are anagrams of each other | ||
| // Time Complexity: ? | ||
| // Space Complexity: ? | ||
| // Time Complexity: O(N^2) |
There was a problem hiding this comment.
✨If you want to include sorting the strings in your time complexity, we could say that the time complexity is O(n m log(m)) where m is the length of the string you are sorting and n is the length of strings
Space complexity would also be O(n) where counter and grouped are each of size n
| return counterArray | ||
| } | ||
|
|
||
| function topKFrequentElements(list, k) { |
There was a problem hiding this comment.
✨ Nice! Since you are sorting the array, it would be O(n log n) time complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions