Open
Conversation
Comment on lines
5
to
+7
| app = Flask(__name__) | ||
| from .routes import planets_bp | ||
| app.register_blueprint(planets_bp) |
There was a problem hiding this comment.
Consider adding a line space to enhance readability
Suggested change
| app = Flask(__name__) | |
| from .routes import planets_bp | |
| app.register_blueprint(planets_bp) | |
| app = Flask(__name__) | |
| from .routes import planets_bp | |
| app.register_blueprint(planets_bp) |
Comment on lines
+37
to
+42
| return { | ||
| "id": planet.id, | ||
| "name": planet.name, | ||
| "description": planet.description, | ||
| "moon": planet.moon | ||
| } |
There was a problem hiding this comment.
Writing an instance method for the Planet class that returns this dictionary with planet data can DRY up your code. You will find that you need to do this work for other route functions too.
kaidamasaki
reviewed
Oct 29, 2021
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Well done!
I had one little note around input validation but overall everything looks great!
Comment on lines
+9
to
+15
| def to_json(self): | ||
| return { | ||
| "id": self.id, | ||
| "name": self.name, | ||
| "description": self.description, | ||
| "moon": self.moon | ||
| } No newline at end of file |
There was a problem hiding this comment.
Nice job adding the helper method Becca recommended. 😃
|
|
||
| @planets_bp.route("/<planet_id>", methods=["GET", "PUT", "DELETE"]) | ||
| def read_planet(planet_id): | ||
| planet = Planet.query.get(planet_id) |
There was a problem hiding this comment.
One thing to note here, you don't verify the type of planet_id so could potentially get a strange error if someone provides invalid data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.