Skip to content

Cedar - Lux Barker#41

Open
k-nox wants to merge 2 commits intoAda-C16:masterfrom
k-nox:master
Open

Cedar - Lux Barker#41
k-nox wants to merge 2 commits intoAda-C16:masterfrom
k-nox:master

Conversation

@k-nox
Copy link
Copy Markdown

@k-nox k-nox commented Jun 17, 2022

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question Answer
What is an ADT? an abstract data type is described by its behavior, not its implementation
Describe a Stack a last-in-first-out data structure
What are the 5 methods in Stack and what does each do? push - adds an element to the top of the stack, pop - grabs an element from the top of the stack, empty - checks if the stack is empty
Describe a Queue a first-in-first-out data structure
What are the 5 methods in Queue and what does each do? enqueue - adds an element to the end of a queue, dequeue - removes an element from the front of the queue, front - peaks at the element at the front of the queue but doesn't remove it, size - returns the size of the queue, empty - returns a boolean for whether the queue is empty or not
What is the difference between implementing something and using something? implementing something requires you to know how something works. using it requires you to know when something is the right tool for the problem and how to use it.

OPTIONAL JobSimulation

Question Answer
Did you include a sample run of your code as a comment? what does this mean/what is the JobSimulation?

Copy link
Copy Markdown

@kyra-patton kyra-patton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨💫 Really clean solution, Lux! Looks like you just missed implementing __str__ for your Stack. Let me know what questions you have.

🟢

Comment thread stacks_queues/queue.py
returns None
"""
pass
# is queue full?
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫 Very readable implementation!

Comment thread stacks_queues/queue.py
self.size -= 1
return element

def front(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/queue.py
raise QueueEmptyException
# grab the element from the front of the queue
element = self.store[self.front]
self.store[self.front] = None
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 Really like that you reset value to None in addition to moving the pointer

Comment thread stacks_queues/queue.py
""" Removes and returns an element from the Queue
Raises a QueueEmptyException if
The Queue is empty.
"""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/queue.py
if self.size > 0:
return self.store[self.front]

def size(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/queue.py
pass
return self.size == 0

def __str__(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/stack.py
Returns None
"""
pass
self.store.add_first(element)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/stack.py
returns None
"""
pass
return self.store.remove_first() if not self.empty() else StackEmptyException()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread stacks_queues/stack.py
pass
return self.store.empty()

def __str__(self):
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Looks like you missed implementing this one!

Comment thread stacks_queues/stack.py
And False otherwise
"""
pass
return self.store.empty()
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants