Open
Conversation
kaidamasaki
reviewed
Dec 13, 2021
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Good job!
It seems like you're still struggling a little with semantic tags and class names but overall things look pretty good! (These problems are really common when learning HTML so you aren't alone.)
| <!-- <div id ="lovely-city"> For the lovely city of</div> | ||
| <div id ="header-city">here change the city dynamically</div> --> | ||
| </section> | ||
| <section id ="whole-body"> |
There was a problem hiding this comment.
This probably wants to be a main tag:
Suggested change
| <section id ="whole-body"> | |
| <main> |
| </head> | ||
| <body> | ||
|
|
||
| <section id ="headers"> |
There was a problem hiding this comment.
Instead of using a section with an id of headers you should instead use a header tag:
Suggested change
| <section id ="headers"> | |
| <header> |
| <body> | ||
|
|
||
| <section id ="headers"> | ||
| <div id ="weather-header"><span class='bigger'>Weather Report</span> |
There was a problem hiding this comment.
Generally we try to avoid using something like bigger as a class name. That way if instead of making the text bigger we decide to make it bold we don't have to rename everything:
Suggested change
| <div id ="weather-header"><span class='bigger'>Weather Report</span> | |
| <div id ="weather-header"><span class='title'>Weather Report</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.