Open
Conversation
…nt listener to up and down arrows to increase or decrease the temperature when clicked
…t listener to be able to select skies accordingly
…ions to change the color of temperature accordingly and also to pick landscape emoji accordingly
… selectCity function to show entered city at the top of a page
…tes temperatureColorControl helper function to control color according to temperature
…cape picture change by creating landscapePictureChange() function, makes temperature and currentLandscape a local variable instead of global
…ictures to weather garden, cleans index.js from commented out code
CheezItMan
reviewed
Dec 13, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Ainur, very clean code and well written. You hit the learning goals here.
| <p>For the lovely city of <span id="currentCity">✨My Hometown✨</span></p> | ||
| </section> | ||
|
|
||
| <section class="box3" class="input-boxes"> |
There was a problem hiding this comment.
Two class attributes?
Suggested change
| <section class="box3" class="input-boxes"> | |
| <section class="box3 input-boxes"> |
| </section> | ||
| <section id="box5"> | ||
| <h3>City Name</h3> | ||
| <label for="name">City Name:</label> |
There was a problem hiding this comment.
The for attribute should match the id of the input
Suggested change
| <label for="name">City Name:</label> | |
| <label for="cityName">City Name:</label> |
|
|
||
| /* .input-boxes { | ||
| /* background-color: aqua; */ | ||
| /* } */ */ |
There was a problem hiding this comment.
Extra */
Suggested change
| /* } */ */ | |
| /* } */ |
| resetCityName.addEventListener('click', resetCity); | ||
| }; | ||
|
|
||
| document.addEventListener('DOMContentLoaded', registerEventHandlers); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.