Open
Conversation
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Great work on this javascript in the web project! The styles are super cool, and you've clearly met the learning goals around applying styles dynamically and event handling. Your code is clear and readable, and makes great use of helper functions. Nice work!
| <body> | ||
|
|
||
| </body> | ||
| </html> No newline at end of file |
There was a problem hiding this comment.
Nice work writing clear, semantic html.
| @@ -0,0 +1,204 @@ | |||
| const state = { | |||
| // rendering | ||
| const renderTemp = () => { | ||
| const { | ||
| temp: { cTemp, fTemp }, |
| }; | ||
|
|
||
| // helper logic for rendering | ||
| const getTempClass = () => { |
There was a problem hiding this comment.
Notice that getTempClass and getLandscapeContent have the same conditional tests. Consider refactoring and combining to DRY up your code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.