Conversation
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Nice work giving this project your own flavor! It's a really cool dynamic page and it's clear you did lots of learning. One of the learning goals of this project was to research how to detect and respond to events for an input and select element. I encourage you to do that research even if those elements aren't on your page.
| let div = document.createElement('div'); | ||
| div.className = 'content'; | ||
| let h3 = document.createElement('h3'); |
There was a problem hiding this comment.
In general we should use const for elements since we will not overwrite these, but modify their attributes
| let section = document.createElement('section'); | ||
| section.className = 'container'; | ||
|
|
||
| if (i < 45) section.style.color = 'rgb(103, 128, 147)'; |
There was a problem hiding this comment.
For consistency, consider sticking with applying classNames to apply styles
| } | ||
|
|
||
| /* a function to create the temps, | ||
| this is the only function syntax i could get to work? |
There was a problem hiding this comment.
I'm not sure why this is the case
| document.body.style.backgroundColor = 'black'; | ||
| } | ||
|
|
||
| /* The code above is responsible for creating the numbers/sections for numbers |
There was a problem hiding this comment.
I noticed that you added your onclick behavior directly to your html rather than adding event listeners in your javascript. Is there a reason you made this choice.
| /* The code above is responsible for creating the numbers/sections for numbers | ||
| and changing the colors/videos from radish to mint. The code below is responsible for | ||
| the scrolling effects. In order for both sections to work I had to place them | ||
| at different places in the html file. I'm not experienced enough to know why |
There was a problem hiding this comment.
I also don't have a lot of experience with vanilla javascript. Let's talk more about who would be a good resource for you!
2 participants
No description provided.