Open
Conversation
jbieniosek
reviewed
Oct 5, 2022
jbieniosek
left a comment
jbieniosek
left a comment
There was a problem hiding this comment.
Great work on this project Emma and Alyssa! The code is very clean and easy to read. This project is green.
| @@ -1,11 +1,51 @@ | |||
| import random | |||
| from adagrams.const_dicts import * | |||
| pass | ||
| letter_pool_list = [] | ||
| for letter, number in LETTER_POOL.items(): | ||
| letter_pool_list.extend([letter]*number) |
There was a problem hiding this comment.
Great way to handle the distribution!
Comment on lines
+9
to
+11
| while len(hand_list) < 10: | ||
| random.shuffle(letter_pool_list) | ||
| hand_list.append(letter_pool_list.pop()) |
There was a problem hiding this comment.
This works well to generate a list of 10 random letters, but it's doing a lot of extra work. random.shuffle will randomize the list, and once it's randomized, selecting the first 10 letters will give you a random hand of letters. Reshuffling between each selection isn't necessary.
| pass | ||
| word = word.upper() | ||
| new_letter_bank = [] | ||
| new_letter_bank.extend(letter_bank) |
| new_letter_bank.extend(letter_bank) | ||
| for letter in word: | ||
| if letter in new_letter_bank: | ||
| new_letter_bank.remove(letter) |
| if len(word) >= 7: | ||
| sum += 8 | ||
| for letter in word: | ||
| sum += SCORE_CHART_DICT[letter] |
| if high_word_length == 10 and word_length < high_word_length or word_length == high_word_length: | ||
| continue | ||
| elif word_length < high_word_length or word_length == 10: | ||
| highest_score_word = word |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.