Conversation
Following Intersar's idea, fixed bugs. Should pass all 4 tests, too.
alope107
left a comment
alope107
left a comment
There was a problem hiding this comment.
Great job! You've got some great code here. In the future, try to make the commits a bit more descriptive so they say what functionality was added, not just what test was passed. Nicely done with this code!
| hand = [] | ||
| while len(hand) < 10: | ||
| random_letter = random.choice(string.ascii_uppercase) | ||
| if hand.count(random_letter) < LETTER_POOL_COUNT[random_letter]: | ||
| hand.append(random_letter) | ||
| continue | ||
| else: | ||
| continue |
There was a problem hiding this comment.
Nice logic! We can slightly simplify things be removing lines 43-44, they are unneeded.
| def uses_available_letters(word, letter_bank): | ||
| pass | ||
| word_case = word.upper() | ||
| letter_count_dict = Counter(letter_bank) | ||
| for letter in word_case: | ||
| if letter in letter_count_dict and letter_count_dict[letter] > 0: | ||
| letter_count_dict[letter] -= 1 | ||
| continue | ||
| else: | ||
| return False | ||
|
|
||
|
|
||
| return True |
There was a problem hiding this comment.
Nice use of Counter! Can you also think through how you would solve this problem without it?
Also, the continue on line 54 is unneeded.
| score_list.append(word_score) | ||
| word_score_dict[word] = word_score | ||
|
|
||
| highest_word_score = max(set(score_list)) |
There was a problem hiding this comment.
The set is unneeded here, max can operate directly on a list.
| for word, score in highest_word_dict.items(): | ||
| if len(word) == 10: | ||
| winning_tuple = (word, score) | ||
| break | ||
| else: | ||
| winning_tuple = list(highest_word_dict.items())[0] |
There was a problem hiding this comment.
Line 95 repeatedly converts the items in a dictionary to a list. Can you think of a way to avoid this?
| # word_to_score_dict = {} | ||
| # for word in word_list: | ||
| # word_score = score_word(word) | ||
| # word_to_score_dict[word] = word_score |
| # word_to_score_dict = {} | ||
| # for word in word_list: | ||
| # word_score = score_word(word) | ||
| # word_to_score_dict[word] = word_score | ||
| # winning_words = [] | ||
| # highest_scoring_word = () | ||
| # highest_scoring_word = (word, word_score) |
There was a problem hiding this comment.
Line 106 will start us with the last word in the data, which is likely not what we want because earlier words should win tiebreaks.
| # for word, word_score in word_to_score_dict.items(): | ||
| # if highest_scoring_word == (): | ||
| # highest_scoring_word = (word, word_score) | ||
| # continue | ||
| # if word_score > highest_scoring_word[1]: | ||
| # highest_scoring_word = (word, word_score) | ||
| # winning_words.append(highest_scoring_word) | ||
|
|
||
| # if word_score == highest_scoring_word[1]: | ||
| # if len(highest_scoring_word[0]) == 10: | ||
| # winning_words.append(highest_scoring_word) | ||
| # return highest_scoring_word | ||
|
|
||
| # if len(word) == 10 and len(highest_scoring_word[0]) <= len(word): | ||
| # highest_scoring_word = (word, word_to_score_dict[word]) | ||
| # winning_words.append(highest_scoring_word) | ||
| # return highest_scoring_word | ||
| # if len(highest_scoring_word[0]) > len(word): | ||
| # highest_scoring_word = (word, word_to_score_dict[word]) | ||
| # elif len(highest_scoring_word[0]) == len(word): | ||
| # highest_scoring_word = (word, word_to_score_dict[word]) | ||
|
|
||
| # winning_words.append(highest_scoring_word) | ||
| # return highest_scoring_word |
There was a problem hiding this comment.
There's a lot of great logic here! I think the main issue this code has is the return statements being inside the for loop. A return statement immediately ends our loop and exits our function, which means that none of our later words would be considered. Moving our return statement outside the loop would solve. lot here!
3 participants
No description provided.