Open
Conversation
CheezItMan
reviewed
Jan 16, 2023
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nicely done Mica, you hit the learning goals here. Well done.
| Z: 1, | ||
| }; | ||
|
|
||
| const LETTERPOINTS = { |
There was a problem hiding this comment.
I like this way of scoring letters and the above object for generating the pool.
Comment on lines
+63
to
+70
| while (i < 10) { | ||
| let letterIndex = Math.floor(Math.random() * 26); | ||
| if (letterPool[letterIndex][1] > 0) { | ||
| hand.push(letterPool[letterIndex][0]); | ||
| letterPool[letterIndex][1] -= 1; | ||
| i += 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
| return hand; | ||
| }; | ||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { |
There was a problem hiding this comment.
👍 I like the helper function and it's an interesting way to do this.
| return true; | ||
| }; | ||
|
|
||
| export const scoreWord = (word) => { |
| return total_score; | ||
| }; | ||
|
|
||
| export const highestScoreFrom = (words) => { |
There was a problem hiding this comment.
👍 I like the helper function and good use of JS functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.