Final version of JS adagrams-Diana S. #133
Open
sorindevops wants to merge 10 commits intoAda-C18:mainfrom
Open
Final version of JS adagrams-Diana S. #133sorindevops wants to merge 10 commits intoAda-C18:mainfrom
sorindevops wants to merge 10 commits intoAda-C18:mainfrom
Conversation
marciaga
reviewed
Dec 23, 2022
marciaga
left a comment
marciaga
left a comment
There was a problem hiding this comment.
Nice job with this one! Specific feedback on lines below.
| @@ -0,0 +1,17 @@ | |||
| { | |||
| // Use IntelliSense to learn about possible attributes. | |||
There was a problem hiding this comment.
This will probably break some aspects of VSCode. JSON format does not support comments like in JavaScript.
|
|
||
| export const drawLetters = () => { | ||
| // Implement this method for wave 1 | ||
| const thisHand = []; |
|
|
||
| it("returns a score of 0 if given an empty input", () => { | ||
| throw "Complete test"; | ||
| expect(scoreWord("")).toBe(0); |
| const correct = { word: "XXXX", score: scoreWord("XXXX") }; | ||
|
|
||
| throw "Complete test by adding an assertion"; | ||
| expect(highestScoreFrom(words)).toEqual(correct); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.