Panthers Jan L. #74
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "dependencies": { | ||
| "axios": "^1.2.1" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| // import axios from 'axios'; | ||
| 'use strict'; | ||
|
|
||
| const state = { | ||
| temp: 32, | ||
| }; | ||
|
|
||
| const plusClickCount = () => { | ||
| const plusContainer = document.getElementById('Temperature'); | ||
| state.temp += 1; | ||
| plusContainer.textContent = state.temp; | ||
| changeColor(); | ||
| }; | ||
|
|
||
| const minusClickCount = () => { | ||
| const minusContainer = document.getElementById('Temperature'); | ||
| state.temp -= 1; | ||
| minusContainer.textContent = state.temp; | ||
| changeColor(); | ||
| }; | ||
| //making text color different | ||
| const changeColor = () => { | ||
| const tempColor = document.querySelector('#Temperature'); | ||
| const newLS = document.getElementById('newLandscape'); | ||
|
|
||
| if (state.temp < 49) { | ||
| tempColor.style.color = 'teal'; | ||
| newLS.src = `assets/cold.jpeg`; | ||
| } else if (state.temp >= 50 && state.temp < 59) { | ||
| tempColor.style.color = 'green'; | ||
| newLS.src = `assets/cool.jpeg`; | ||
| } else if (state.temp >= 60 && state.temp < 69) { | ||
| tempColor.style.color = 'yellow'; | ||
| newLS.src = `assets/warm.jpeg`; | ||
| } else if (state.temp >= 70 && state.temp < 79) { | ||
| tempColor.style.color = 'orange'; | ||
| newLS.src = `assets/beach.jpeg`; | ||
| } else if (state.temp >= 80) { | ||
| tempColor.style.color = 'red'; | ||
| newLS.src = `assets/hot1.jpeg`; | ||
| } | ||
| }; | ||
|
|
||
| //wave 4 axios call | ||
| const realTimeClick = () => { | ||
| let query = input.value; | ||
| // displayTemp(); | ||
| findLocationWeather(query); | ||
| }; | ||
|
|
||
| const displayTemp = () => { | ||
| let tempContainer = document.getElementById('Temperature'); | ||
| tempContainer.textContent = state.temp; | ||
| }; | ||
|
|
||
| const findLocationWeather = (query) => { | ||
| axios | ||
| .get('http://127.0.0.1:5000/location', { | ||
| params: { | ||
| format: 'json', | ||
| q: query, | ||
| }, | ||
| }) | ||
| .then((response) => { | ||
| let latitude = response.data[0].lat; | ||
| let longitude = response.data[0].lon; | ||
| axios | ||
| .get('http://127.0.0.1:5000/weather', { | ||
| params: { | ||
| format: 'json', | ||
| lat: latitude, | ||
| lon: longitude, | ||
| }, | ||
| }) | ||
| .then((response) => { | ||
| console.log('success in findWeather!', response.data); | ||
| const currentTemp = Math.floor( | ||
| (Number(response.data.main.temp) - 273.15) * 1.8 + 32 | ||
| ); | ||
| state.temp = currentTemp; | ||
| changeColor(); | ||
| displayTemp(); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('error in findweather!', error); | ||
| }); | ||
| }) | ||
| .catch((error) => { | ||
| console.log('error!', error); | ||
| }); | ||
| }; | ||
|
There was a problem hiding this comment. You handled this nested promise chaining very well! However there is a way we can make this code more concise! Making use of the const findLocation = async (query) => {
try {
const coordinates = await axios.get('http://127.0.0.1:5000/location', {
params: {
q: query,
format: 'json',
}})
let latitude = coordinates.data[0].lat;
let longitude = coordinates.data[0].lon;
findWeather(latitude, longitude)
} catch (err) {
console.log(err)
}
} Essentially, the |
||
|
|
||
| //wave 5 | ||
|
|
||
| const selectSky = document.querySelector('.sky'); | ||
|
|
||
| selectSky.addEventListener('change', (event) => { | ||
| const result = document.querySelector('.result'); | ||
| result.textContent = `The sky is ${event.target.value}`; | ||
|
There was a problem hiding this comment. I love this use of the event object! |
||
| }); | ||
|
|
||
| //wave 3 update text | ||
| const input = document.querySelector('input'); | ||
| const log = document.getElementById('values'); | ||
|
|
||
| input.addEventListener('input', updateValue); | ||
|
|
||
| function updateValue(e) { | ||
| log.textContent = e.target.value; | ||
| } | ||
| //wave 6 | ||
| const resetCity = () => { | ||
| input.value = ''; | ||
| log.textContent = ''; | ||
| }; | ||
|
|
||
| const registerEventHandlers = () => { | ||
| const hotterButton = document.getElementById('plusButton'); | ||
| hotterButton.addEventListener('click', plusClickCount); | ||
| const coolerButton = document.getElementById('minusButton'); | ||
| coolerButton.addEventListener('click', minusClickCount); | ||
| let realTimeButton = document.getElementById('realTimeButton'); | ||
| realTimeButton.addEventListener('click', realTimeClick); | ||
| const reset = document.getElementById('resetButton'); | ||
| reset.addEventListener('click', resetCity); | ||
| }; | ||
|
|
||
|
|
||
| document.addEventListener('DOMContentLoaded', registerEventHandlers); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| body { | ||
| display: grid; | ||
| grid-template-columns: 1fr 2fr; | ||
| grid-template-rows: auto auto ; | ||
| grid-gap: 1rem; | ||
| font-family: "Rubik", sans-serif; | ||
| font-size: 18px; | ||
| background-color: #a2b8df; | ||
| margin: 5rem; | ||
| } | ||
|
|
||
| .temp_section,.button_section { | ||
| background-color: hwb(102 67% 17%); | ||
| border: none; | ||
| color: green; | ||
| padding: 15px 32px; | ||
| text-align: center; | ||
| text-decoration: none; | ||
| display: inline-block; | ||
| font-size: 16px; | ||
| border-radius: 10px; | ||
| grid-column: 1; | ||
| grid-row:1 | ||
| } | ||
| .sky_section { | ||
| background-color: hwb(102 67% 17%); | ||
| border: none; | ||
| color: green; | ||
| padding: 15px 32px; | ||
| text-align: center; | ||
| text-decoration: none; | ||
| display: inline-block; | ||
| font-size: 16px; | ||
| border-radius: 10px; | ||
| grid-column: 1; | ||
| grid-row:2 | ||
| } | ||
| img{ | ||
| width: 500px; | ||
| } | ||
| .landscape{ | ||
| grid-column: 2; | ||
| grid-row:1/span 2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here is correct, the only thing that is that you didn't need to put
state.temp >= 50 && state.temp < 59and then(state.temp >= 60 && state.temp < 69). You could just dostate.temp > 50andstate.temp > 60. These take care of the range between these two numbers.