Kindra + Reyna + Thao (Tigers) - Weather Report#78
Open
reynamdiaz wants to merge 25 commits intoAda-C18:mainfrom
Open
Kindra + Reyna + Thao (Tigers) - Weather Report#78reynamdiaz wants to merge 25 commits intoAda-C18:mainfrom
reynamdiaz wants to merge 25 commits intoAda-C18:mainfrom
Conversation
apradoada
reviewed
Jan 30, 2023
apradoada
left a comment
apradoada
left a comment
There was a problem hiding this comment.
All in all this was a really well done project! GREEN!
| <div class="temperature_content"> | ||
| <div class="temperature_buttons"> | ||
| <span id="increaseTemp">⬆️</span> | ||
| <span id="temperatureValue" class="blue"> 58°f </span> |
There was a problem hiding this comment.
Not a big deal, but you could leave this element empty and inject your initial state value on first page load. The same goes for lines 47 and 48!
| </body> | ||
| </html> No newline at end of file | ||
|
|
||
| </html> |
| lon: -74.1979576, | ||
| temp: 58, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Great example of creating state here!
| const inputCity = document.getElementById('inputCity'); | ||
| inputCity.value = 'Toms River'; | ||
| updateCity(); | ||
| }; |
There was a problem hiding this comment.
Nice use of the helper function here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.