Skip to content

Tigers- Lindsey B. & Masha #81

Open
Lindseymarcea wants to merge 14 commits intoAda-C18:mainfrom
Lindseymarcea:main
Open

Tigers- Lindsey B. & Masha #81
Lindseymarcea wants to merge 14 commits intoAda-C18:mainfrom
Lindseymarcea:main

Conversation

@Lindseymarcea
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@apradoada apradoada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this isn't exactly the version of the html/javascript combos we ended up doing, I can tell y'all have a really good grasp of both html and javascript!

Comment thread index.html
<header class="header">
Weather Report <span>for the lovely city of
<span id="headerCityName">
Seattle
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally fine but remember that you could keep this empty and then load the default state when you begin!

Comment thread index.html
<div class="temperature_content">
<div class="change_temperature">
<span id="increaseTemp">⬆️</span>
<span id="temp">70</span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as above! This could be loaded in from the default state!

Comment thread index.html


<script src="./node_modules/axios/dist/axios.min.js"></script>
<script src="/src/index.js"></script>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, your html looks really good here! Well done!

Comment thread src/index.js
lat: 47.6062,
lon: -122.3321,
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job creating a default state here!

Comment thread src/index.js
state.temp -= 1;
changeColorAndGarden();
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of helper functions!

Comment thread src/index.js
const cityInput = document.getElementById('cityNameInput');
cityNameInput.value = 'Seattle';
modifyCityName();
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More helper functions! Well done!

Comment thread src/index.js
.catch((error) => {
console.log('Error calling OpenWeather');
});
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with these axios functions. The move to make them async functions was a really smart choice!

Comment thread src/index.js

getWeather();
const getTemp = document.getElementById('getTemp');
getTemp.addEventListener('click', getWeather);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants