Open
Conversation
…key, but i don't know if it worked yet
… to be registered. then i got event handlers to be called (before, it wasn't being called
…uttons, it goes back to 60 degrees as a baseline.
…. then it increments up or down when i press the buttons. yay
nancy-harris
left a comment
nancy-harris
left a comment
There was a problem hiding this comment.
Good job! This project is graded as yellow. Please see the comments below for more information.
Comment on lines
+64
to
+65
| const lat = 47.6038321; | ||
| const lon = -122.330062; |
There was a problem hiding this comment.
One of the requirements for Wave 4 was to make two Axios calls and chain them. Rather than hard-coding the lat and lon for Seattle, we wanted you to be able to get this information from the proxy server and then send the information back to the proxy server to get the temperature. This makes the project a yellow.
| console.log(downButton); | ||
| }; | ||
|
|
||
| registerEventHandlers(undefined); |
There was a problem hiding this comment.
Rather than sending undefined into the function, you could leave it blank and also have the registerEventHandlers function not take in any parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LP's individual work (after group co-working part)